[PR #3178] [MERGED] Add separate Authority method for AXFR #3618

New issue

Closed

opened 2026-03-16 11:53:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:53:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3178
Author: @divergentdave
Created: 8/6/2025
Status: ✅ Merged
Merged: 8/8/2025
Merged by: @divergentdave

Base: main ← Head: david/split-authority-axfr

📝 Commits (10+)

a1cfc97 Remove obsolete comment
612a053 Update variable names
888470e Add separate method for AXFR to Authority
6ab28c3 Remove AXFR from AuthLookup
16feaef Clean up clones before lookup call
f5d765c Rewrite test that used low-level AXFR lookups
ac46ce5 Replace use of lookup() for the bulk of AXFRs
72e8e4e Replace use of AnyRecords in AXFR
ebac825 Clean up internals of AnyRecords
d2d9384 Remove TODO comment

📊 Changes

12 files changed (+420 additions, -180 deletions)

View changed files

📝 crates/server/src/authority/auth_lookup.rs (+99 -40)
📝 crates/server/src/authority/authority.rs (+13 -1)
📝 crates/server/src/authority/catalog.rs (+108 -16)
📝 crates/server/src/authority/mod.rs (+2 -1)
📝 crates/server/src/store/blocklist.rs (+12 -1)
📝 crates/server/src/store/file.rs (+13 -1)
📝 crates/server/src/store/forwarder.rs (+17 -1)
📝 crates/server/src/store/in_memory/mod.rs (+63 -66)
📝 crates/server/src/store/recursor.rs (+17 -0)
📝 crates/server/src/store/sqlite/mod.rs (+33 -16)
📝 tests/integration-tests/tests/integration/chained_authority_tests.rs (+12 -1)
📝 tests/integration-tests/tests/integration/sqlite_authority_tests.rs (+31 -36)

📄 Description

This splits AXFR handling off into a different Authority method, in line with the first bullet point of #3169. AuthLookup::AXFR is split off into a separate struct, and AnyRecords is split into two structs, as it was previously used for both ANY and AXFR pseudo-type queries.

This PR simplifies the return types of Authority methods and removes an internal Authority::lookup() call, paving the way for future improvements to the Authority trait, and lays the groundwork for fixing issues with AXFR support.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3178 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 8/6/2025 **Status:** ✅ Merged **Merged:** 8/8/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/split-authority-axfr` --- ### 📝 Commits (10+) - [`a1cfc97`](https://github.com/hickory-dns/hickory-dns/commit/a1cfc971f18b04d48ff7fd1062752a926e3f0ca6) Remove obsolete comment - [`612a053`](https://github.com/hickory-dns/hickory-dns/commit/612a053c07e31fa5f2f444941d503a3bad3a5f75) Update variable names - [`888470e`](https://github.com/hickory-dns/hickory-dns/commit/888470e4b9d856b0c9397048f519ccf707c8a602) Add separate method for AXFR to Authority - [`6ab28c3`](https://github.com/hickory-dns/hickory-dns/commit/6ab28c34e8bb0ea4149faf34e1737bd18649dd30) Remove AXFR from AuthLookup - [`16feaef`](https://github.com/hickory-dns/hickory-dns/commit/16feaef35308c999f87a61843ce4e3ea061458b5) Clean up clones before lookup call - [`f5d765c`](https://github.com/hickory-dns/hickory-dns/commit/f5d765cb692d0caacaa84e57a14eb02813ad0718) Rewrite test that used low-level AXFR lookups - [`ac46ce5`](https://github.com/hickory-dns/hickory-dns/commit/ac46ce5e7966361c5da3860bfc5fe863056b1806) Replace use of lookup() for the bulk of AXFRs - [`72e8e4e`](https://github.com/hickory-dns/hickory-dns/commit/72e8e4e28df15e76291408249a069d09b7be5e75) Replace use of AnyRecords in AXFR - [`ebac825`](https://github.com/hickory-dns/hickory-dns/commit/ebac825873c2b7728d66e944ca9333707ca06ba6) Clean up internals of AnyRecords - [`d2d9384`](https://github.com/hickory-dns/hickory-dns/commit/d2d93849e87fb7064618768791cb9dc3bf5cab59) Remove TODO comment ### 📊 Changes **12 files changed** (+420 additions, -180 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/authority/auth_lookup.rs` (+99 -40) 📝 `crates/server/src/authority/authority.rs` (+13 -1) 📝 `crates/server/src/authority/catalog.rs` (+108 -16) 📝 `crates/server/src/authority/mod.rs` (+2 -1) 📝 `crates/server/src/store/blocklist.rs` (+12 -1) 📝 `crates/server/src/store/file.rs` (+13 -1) 📝 `crates/server/src/store/forwarder.rs` (+17 -1) 📝 `crates/server/src/store/in_memory/mod.rs` (+63 -66) 📝 `crates/server/src/store/recursor.rs` (+17 -0) 📝 `crates/server/src/store/sqlite/mod.rs` (+33 -16) 📝 `tests/integration-tests/tests/integration/chained_authority_tests.rs` (+12 -1) 📝 `tests/integration-tests/tests/integration/sqlite_authority_tests.rs` (+31 -36) </details> ### 📄 Description This splits AXFR handling off into a different `Authority` method, in line with the first bullet point of #3169. `AuthLookup::AXFR` is split off into a separate struct, and `AnyRecords` is split into two structs, as it was previously used for both `ANY` and `AXFR` pseudo-type queries. This PR simplifies the return types of `Authority` methods and removes an internal `Authority::lookup()` call, paving the way for future improvements to the `Authority` trait, and lays the groundwork for fixing issues with `AXFR` support. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>