[PR #3164] [MERGED] Blocklist client logging #3609

New issue

Closed

opened 2026-03-16 11:52:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:52:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3164
Author: @marcus0x62
Created: 7/28/2025
Status: ✅ Merged
Merged: 7/30/2025
Merged by: @divergentdave

Base: main ← Head: blocklist_client_logging

📝 Commits (2)

19542de pass RequestInfo to lookup and consult when available
3c0f8ca blocklist client IP logging

📊 Changes

15 files changed (+198 additions, -50 deletions)

View changed files

📝 bin/tests/integration/forwarder.rs (+1 -0)
📝 bin/tests/integration/in_memory.rs (+3 -0)
📝 bin/tests/integration/store_file_tests.rs (+1 -1)
📝 bin/tests/integration/txt_tests.rs (+12 -0)
📝 crates/server/src/authority/authority.rs (+14 -5)
📝 crates/server/src/authority/catalog.rs (+1 -0)
📝 crates/server/src/store/blocklist.rs (+55 -21)
📝 crates/server/src/store/file.rs (+8 -2)
📝 crates/server/src/store/forwarder.rs (+3 -1)
📝 crates/server/src/store/in_memory/mod.rs (+24 -6)
📝 crates/server/src/store/recursor.rs (+3 -1)
📝 crates/server/src/store/sqlite/mod.rs (+12 -5)
📝 tests/integration-tests/tests/integration/chained_authority_tests.rs (+4 -1)
📝 tests/integration-tests/tests/integration/sqlite_authority_tests.rs (+56 -7)
📝 tests/test-data/test_configs/chained_blocklist.toml (+1 -0)

📄 Description

This adds support for client IP logging in the blocklist. It requires a (semver-incompatible) change to the Authority trait.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3164 **Author:** [@marcus0x62](https://github.com/marcus0x62) **Created:** 7/28/2025 **Status:** ✅ Merged **Merged:** 7/30/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `blocklist_client_logging` --- ### 📝 Commits (2) - [`19542de`](https://github.com/hickory-dns/hickory-dns/commit/19542de0892fd7c20206c2a8a17a267fdf346e79) pass RequestInfo to lookup and consult when available - [`3c0f8ca`](https://github.com/hickory-dns/hickory-dns/commit/3c0f8ca090e4df3caa52f650cf3f3e72a97b5fb2) blocklist client IP logging ### 📊 Changes **15 files changed** (+198 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/forwarder.rs` (+1 -0) 📝 `bin/tests/integration/in_memory.rs` (+3 -0) 📝 `bin/tests/integration/store_file_tests.rs` (+1 -1) 📝 `bin/tests/integration/txt_tests.rs` (+12 -0) 📝 `crates/server/src/authority/authority.rs` (+14 -5) 📝 `crates/server/src/authority/catalog.rs` (+1 -0) 📝 `crates/server/src/store/blocklist.rs` (+55 -21) 📝 `crates/server/src/store/file.rs` (+8 -2) 📝 `crates/server/src/store/forwarder.rs` (+3 -1) 📝 `crates/server/src/store/in_memory/mod.rs` (+24 -6) 📝 `crates/server/src/store/recursor.rs` (+3 -1) 📝 `crates/server/src/store/sqlite/mod.rs` (+12 -5) 📝 `tests/integration-tests/tests/integration/chained_authority_tests.rs` (+4 -1) 📝 `tests/integration-tests/tests/integration/sqlite_authority_tests.rs` (+56 -7) 📝 `tests/test-data/test_configs/chained_blocklist.toml` (+1 -0) </details> ### 📄 Description This adds support for client IP logging in the blocklist. It requires a (semver-incompatible) change to the Authority trait. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>