[PR #3161] [MERGED] Result handling cleanup #3603

New issue

Closed

opened 2026-03-16 11:52:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:52:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3161
Author: @divergentdave
Created: 7/25/2025
Status: ✅ Merged
Merged: 7/26/2025
Merged by: @divergentdave

Base: main ← Head: david/ok-err-cleanup

📝 Commits (3)

9de517f Use let instead of ok() to ignore results
def57a8 Simplify result handling by destructuring
6f9e006 Don't use ok() or err() when unwrapping

📊 Changes

10 files changed (+33 additions, -34 deletions)

View changed files

📝 bin/tests/integration/named_test_rsa_dnssec.rs (+1 -1)
📝 bin/tests/integration/store_sqlite_tests.rs (+4 -4)
📝 bin/tests/integration/txt_tests.rs (+10 -10)
📝 crates/client/src/client/rc_stream.rs (+4 -4)
📝 crates/proto/src/multicast/mdns_stream.rs (+2 -2)
📝 crates/proto/src/quic/quic_stream.rs (+6 -6)
📝 crates/proto/src/serialize/txt/zone.rs (+2 -2)
📝 crates/proto/src/tests/udp.rs (+1 -1)
📝 crates/proto/src/xfer/dns_exchange.rs (+2 -3)
📝 tests/compatibility-tests/src/lib.rs (+1 -1)

📄 Description

This cleans up some non-idiomatic uses of ok() and err().

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3161 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 7/25/2025 **Status:** ✅ Merged **Merged:** 7/26/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/ok-err-cleanup` --- ### 📝 Commits (3) - [`9de517f`](https://github.com/hickory-dns/hickory-dns/commit/9de517f463093c510a1a82992dd933f51de39060) Use let instead of ok() to ignore results - [`def57a8`](https://github.com/hickory-dns/hickory-dns/commit/def57a82cb686e76e5436aaa5cf86369b92a3edf) Simplify result handling by destructuring - [`6f9e006`](https://github.com/hickory-dns/hickory-dns/commit/6f9e006d421bb5a454f8c1ff2ec06e98b772b33b) Don't use ok() or err() when unwrapping ### 📊 Changes **10 files changed** (+33 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+1 -1) 📝 `bin/tests/integration/store_sqlite_tests.rs` (+4 -4) 📝 `bin/tests/integration/txt_tests.rs` (+10 -10) 📝 `crates/client/src/client/rc_stream.rs` (+4 -4) 📝 `crates/proto/src/multicast/mdns_stream.rs` (+2 -2) 📝 `crates/proto/src/quic/quic_stream.rs` (+6 -6) 📝 `crates/proto/src/serialize/txt/zone.rs` (+2 -2) 📝 `crates/proto/src/tests/udp.rs` (+1 -1) 📝 `crates/proto/src/xfer/dns_exchange.rs` (+2 -3) 📝 `tests/compatibility-tests/src/lib.rs` (+1 -1) </details> ### 📄 Description This cleans up some non-idiomatic uses of `ok()` and `err()`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>