mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[PR #3152] [MERGED] util: tidy logging, add trace level support, fix library logging #3599
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#3599
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hickory-dns/hickory-dns/pull/3152
Author: @cpu
Created: 7/23/2025
Status: ✅ Merged
Merged: 7/23/2025
Merged by: @djc
Base:
main← Head:cpu-util-tidy_dev📝 Commits (8)
3a23fe4util: fix stale TrustDNS refe3577deutil: lift up common log level handling4efbd88util: add trace level logging CLI arga9a5c3cutil: lift up Some(_) in LogConfig::level()a2e76d2util: simplify get_levels()638729futil: use 'hickory=' for level stra3f584eutil: inline logger() formatter, rename arg to cli_level8e4a015util: fix recurse binary rustdoc comment📊 Changes
4 files changed (+75 additions, -112 deletions)
View changed files
📝
util/src/bin/dns.rs(+5 -30)📝
util/src/bin/recurse.rs(+5 -29)📝
util/src/bin/resolve.rs(+4 -28)📝
util/src/lib.rs(+61 -25)📄 Description
I wasn't able to get any useful information out of the
recurse.rsutility when setting--debugand it sent me down a bit of a rabbit hole.The TL;DR is that I think the util
get_levels()helper should be usinghickory={level}nothickory_dns={level}to try and configure the sub-crate logging levels alongside the utility binary. With that change in place I seehickory_proto,hickory_resolver,hickory_recursor, etc log lines at the expected level.Before this branch:
Wtith this branch:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.