[PR #3148] [MERGED] ProtoErrorKind cleanup #3598

New issue

Closed

opened 2026-03-16 11:52:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:52:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3148
Author: @divergentdave
Created: 7/22/2025
Status: ✅ Merged
Merged: 7/23/2025
Merged by: @djc

Base: main ← Head: david/protoerrorkind-cleanup

📝 Commits (3)

ab0eaf4 Fix copied error variant documentation
6a954a2 Replace use of ProtoErrorKind::NoError
66488f1 Remove ProtoErrorKind::NoError

📊 Changes

4 files changed (+21 additions, -27 deletions)

View changed files

📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+18 -18)
📝 crates/proto/src/error.rs (+2 -7)
📝 crates/proto/src/serialize/binary/decoder.rs (+1 -1)
📝 crates/resolver/src/name_server/name_server.rs (+0 -1)

📄 Description

This removes ProtoErrorKind::NoError and fixes some copied documentation.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3148 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 7/22/2025 **Status:** ✅ Merged **Merged:** 7/23/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/protoerrorkind-cleanup` --- ### 📝 Commits (3) - [`ab0eaf4`](https://github.com/hickory-dns/hickory-dns/commit/ab0eaf4192cbdee8e2be4b69ee746eefd695ec2e) Fix copied error variant documentation - [`6a954a2`](https://github.com/hickory-dns/hickory-dns/commit/6a954a2c71ba31226826c0e2b12d053f58fd0b77) Replace use of ProtoErrorKind::NoError - [`66488f1`](https://github.com/hickory-dns/hickory-dns/commit/66488f1653f31fde1aeefe2e2e9f86c7be8f5c1c) Remove ProtoErrorKind::NoError ### 📊 Changes **4 files changed** (+21 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+18 -18) 📝 `crates/proto/src/error.rs` (+2 -7) 📝 `crates/proto/src/serialize/binary/decoder.rs` (+1 -1) 📝 `crates/resolver/src/name_server/name_server.rs` (+0 -1) </details> ### 📄 Description This removes `ProtoErrorKind::NoError` and fixes some copied documentation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>