[PR #3118] [MERGED] Fix client integration tests #3573

New issue

Closed

opened 2026-03-16 11:50:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:50:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3118
Author: @divergentdave
Created: 7/14/2025
Status: ✅ Merged
Merged: 7/14/2025
Merged by: @djc

Base: main ← Head: david/fix-client-integration-tests

📝 Commits (2)

cb233e9 Await futures in client integration tests
bc00112 Clean up comments

📊 Changes

1 file changed (+8 additions, -9 deletions)

View changed files

📝 tests/integration-tests/tests/integration/dnssec_client_handle_tests.rs (+8 -9)

📄 Description

I tried running some DNSSEC client tests with logging turned up, and noticed that the client query was not actually taking place. This PR fixes the tests by awaiting futures returned when calling test functions that are passed in.

FWIW, rustc cannot produce a warning to catch this mistake as-written, but it does warn when I replace the type variables and where clauses with impl AsyncFn. See https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=323890d55918c263ce3ed0f9e53d94e8. Note that AsyncFn was only just stabilized in 1.85.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3118 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 7/14/2025 **Status:** ✅ Merged **Merged:** 7/14/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/fix-client-integration-tests` --- ### 📝 Commits (2) - [`cb233e9`](https://github.com/hickory-dns/hickory-dns/commit/cb233e9f2718080380d82f734fa4e82fe36a4730) Await futures in client integration tests - [`bc00112`](https://github.com/hickory-dns/hickory-dns/commit/bc00112f2f01a97be8936b305c8e8ad3bf849677) Clean up comments ### 📊 Changes **1 file changed** (+8 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `tests/integration-tests/tests/integration/dnssec_client_handle_tests.rs` (+8 -9) </details> ### 📄 Description I tried running some DNSSEC client tests with logging turned up, and noticed that the client query was not actually taking place. This PR fixes the tests by awaiting futures returned when calling test functions that are passed in. FWIW, rustc cannot produce a warning to catch this mistake as-written, but it does warn when I replace the type variables and where clauses with `impl AsyncFn`. See https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=323890d55918c263ce3ed0f9e53d94e8. Note that `AsyncFn` was only just stabilized in 1.85. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>