[PR #3108] [MERGED] Add accessor to AuthLookup #3567

New issue

Closed

opened 2026-03-16 11:50:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:50:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3108
Author: @divergentdave
Created: 7/11/2025
Status: ✅ Merged
Merged: 7/11/2025
Merged by: @divergentdave

Base: main ← Head: david/authlookup-additional-getter

📝 Commits (1)

97aced9 Add accessor to AuthLookup

📊 Changes

3 files changed (+34 additions, -48 deletions)

View changed files

📝 bin/tests/integration/authority_battery/basic.rs (+20 -38)
📝 bin/tests/integration/in_memory.rs (+6 -10)
📝 crates/server/src/authority/auth_lookup.rs (+8 -0)

📄 Description

This cherry-picks one commit from #3107, adding an accessor to AuthLookup as an alternative to take_additionals(). Using this simplifies various tests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3108 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 7/11/2025 **Status:** ✅ Merged **Merged:** 7/11/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/authlookup-additional-getter` --- ### 📝 Commits (1) - [`97aced9`](https://github.com/hickory-dns/hickory-dns/commit/97aced93f51f390b0ca84a9a63ecca6ac5a3c571) Add accessor to AuthLookup ### 📊 Changes **3 files changed** (+34 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/basic.rs` (+20 -38) 📝 `bin/tests/integration/in_memory.rs` (+6 -10) 📝 `crates/server/src/authority/auth_lookup.rs` (+8 -0) </details> ### 📄 Description This cherry-picks one commit from #3107, adding an accessor to `AuthLookup` as an alternative to `take_additionals()`. Using this simplifies various tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>