[PR #3109] [MERGED] Plumb recursive response message #3566

New issue

Closed

opened 2026-03-16 11:50:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:50:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3109
Author: @divergentdave
Created: 7/11/2025
Status: ✅ Merged
Merged: 7/14/2025
Merged by: @divergentdave

Base: main ← Head: david/plumb-recursive-response-message

📝 Commits (3)

e4e57f5 Add variants to store a Message in AuthLookup
de0af60 Return entire response from RecursiveAuthority
75d03e8 Replace type annotations with turbofishes

📊 Changes

4 files changed (+56 additions, -38 deletions)

View changed files

📝 bin/tests/integration/authority_battery/basic.rs (+9 -9)
📝 bin/tests/integration/in_memory.rs (+11 -7)
📝 crates/server/src/authority/auth_lookup.rs (+33 -4)
📝 crates/server/src/store/recursor.rs (+3 -18)

📄 Description

This adds a new variant to AuthLookup that stores an entire DNS message, and a corresponding variant to LookupRecords that stores a vector of records. It also changes the RecursiveAuthority to return this new variant, instead of returning just the Answer section in a Lookup.

As a result, we can now return Additional section records. Returning Authority section records will require build_forwarded_response() in a subsequent PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3109 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 7/11/2025 **Status:** ✅ Merged **Merged:** 7/14/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/plumb-recursive-response-message` --- ### 📝 Commits (3) - [`e4e57f5`](https://github.com/hickory-dns/hickory-dns/commit/e4e57f5668de9cdad0361d15f8beb8a4016e95f3) Add variants to store a Message in AuthLookup - [`de0af60`](https://github.com/hickory-dns/hickory-dns/commit/de0af604759daec6cf995044bc1ac21df798f240) Return entire response from RecursiveAuthority - [`75d03e8`](https://github.com/hickory-dns/hickory-dns/commit/75d03e8df9b1a37a1162fb2e7432e326ddbacf39) Replace type annotations with turbofishes ### 📊 Changes **4 files changed** (+56 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/basic.rs` (+9 -9) 📝 `bin/tests/integration/in_memory.rs` (+11 -7) 📝 `crates/server/src/authority/auth_lookup.rs` (+33 -4) 📝 `crates/server/src/store/recursor.rs` (+3 -18) </details> ### 📄 Description This adds a new variant to `AuthLookup` that stores an entire DNS message, and a corresponding variant to `LookupRecords` that stores a vector of records. It also changes the `RecursiveAuthority` to return this new variant, instead of returning just the Answer section in a `Lookup`. As a result, we can now return Additional section records. Returning Authority section records will require `build_forwarded_response()` in a subsequent PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>