[PR #3106] [MERGED] Change field and method names for Authority section of messages #3564

New issue

Closed

opened 2026-03-16 11:50:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:50:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3106
Author: @divergentdave
Created: 7/10/2025
Status: ✅ Merged
Merged: 7/11/2025
Merged by: @divergentdave

Base: main ← Head: david/rename-authority-section

📝 Commits (3)

41584ef Rename name_servers to authorities in Message, etc
5b28862 Revise Message method documentation
ef7f9be Remove more unnecessary type annotations

📊 Changes

25 files changed (+220 additions, -220 deletions)

View changed files

📝 crates/proto/benches/lib.rs (+3 -3)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+12 -12)
📝 crates/proto/src/dnssec/rdata/tsig.rs (+3 -3)
📝 crates/proto/src/error.rs (+3 -3)
📝 crates/proto/src/op/header.rs (+15 -15)
📝 crates/proto/src/op/message.rs (+84 -84)
📝 crates/proto/src/op/update_message.rs (+4 -4)
📝 crates/proto/src/xfer/dns_response.rs (+19 -19)
📝 crates/recursor/src/lib.rs (+1 -1)
📝 crates/recursor/src/recursor.rs (+3 -3)
📝 crates/resolver/src/cache.rs (+1 -1)
📝 crates/resolver/src/caching_client.rs (+2 -2)
📝 crates/server/src/authority/message_request.rs (+11 -11)
📝 crates/server/src/authority/message_response.rs (+15 -15)
📝 crates/server/src/server/mod.rs (+1 -1)
📝 fuzz/fuzz_targets/message.rs (+1 -1)
📝 fuzz/fuzz_targets/preserve_rdata.rs (+2 -2)
📝 tests/integration-tests/src/lib.rs (+1 -1)
📝 tests/integration-tests/src/mock_client.rs (+2 -2)
📝 tests/integration-tests/src/mock_request_handler.rs (+1 -1)

...and 5 more files

📄 Description

The field representing the Authority section of messages has been named name_servers up to now, presumably after NSCOUNT in the header. I think it is clearer to use authority or authorities, after the name of the section itself.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3106 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 7/10/2025 **Status:** ✅ Merged **Merged:** 7/11/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/rename-authority-section` --- ### 📝 Commits (3) - [`41584ef`](https://github.com/hickory-dns/hickory-dns/commit/41584efd8ade9a7ceaef79c701cec891e8b46f60) Rename name_servers to authorities in Message, etc - [`5b28862`](https://github.com/hickory-dns/hickory-dns/commit/5b28862d0bc9c755f6277ec61dc4422545d1cfd2) Revise Message method documentation - [`ef7f9be`](https://github.com/hickory-dns/hickory-dns/commit/ef7f9be988b47a0d1ba020564bf30ca373b7f5cf) Remove more unnecessary type annotations ### 📊 Changes **25 files changed** (+220 additions, -220 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/benches/lib.rs` (+3 -3) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+12 -12) 📝 `crates/proto/src/dnssec/rdata/tsig.rs` (+3 -3) 📝 `crates/proto/src/error.rs` (+3 -3) 📝 `crates/proto/src/op/header.rs` (+15 -15) 📝 `crates/proto/src/op/message.rs` (+84 -84) 📝 `crates/proto/src/op/update_message.rs` (+4 -4) 📝 `crates/proto/src/xfer/dns_response.rs` (+19 -19) 📝 `crates/recursor/src/lib.rs` (+1 -1) 📝 `crates/recursor/src/recursor.rs` (+3 -3) 📝 `crates/resolver/src/cache.rs` (+1 -1) 📝 `crates/resolver/src/caching_client.rs` (+2 -2) 📝 `crates/server/src/authority/message_request.rs` (+11 -11) 📝 `crates/server/src/authority/message_response.rs` (+15 -15) 📝 `crates/server/src/server/mod.rs` (+1 -1) 📝 `fuzz/fuzz_targets/message.rs` (+1 -1) 📝 `fuzz/fuzz_targets/preserve_rdata.rs` (+2 -2) 📝 `tests/integration-tests/src/lib.rs` (+1 -1) 📝 `tests/integration-tests/src/mock_client.rs` (+2 -2) 📝 `tests/integration-tests/src/mock_request_handler.rs` (+1 -1) _...and 5 more files_ </details> ### 📄 Description The field representing the Authority section of messages has been named `name_servers` up to now, presumably after `NSCOUNT` in the header. I think it is clearer to use `authority` or `authorities`, after the name of the section itself. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>