[PR #3107] [CLOSED] Add an Authority section to `AuthLookup` #3561

New issue

Closed

opened 2026-03-16 11:50:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:50:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3107
Author: @divergentdave
Created: 7/10/2025
Status: ❌ Closed

Base: david/rename-authority-section ← Head: david/authlookup-authority-section

📝 Commits (7)

3dbbbde Rename name_servers to authorities in Message, etc
d206d1b Revise Message method documentation
15a20ad Remove more unnecessary type annotations
f6e78f5 Rename AuthLookup constructor method
faf4d3b Use constructor method in more places
3378c58 Add accessor to AuthLookup
7f41488 Add Authority section to AuthLookup

📊 Changes

30 files changed (+298 additions, -290 deletions)

View changed files

📝 bin/tests/integration/authority_battery/basic.rs (+20 -38)
📝 bin/tests/integration/in_memory.rs (+6 -10)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+12 -12)
📝 crates/proto/src/dnssec/rdata/tsig.rs (+3 -3)
📝 crates/proto/src/error.rs (+3 -3)
📝 crates/proto/src/op/header.rs (+15 -15)
📝 crates/proto/src/op/message.rs (+84 -84)
📝 crates/proto/src/op/update_message.rs (+4 -4)
📝 crates/proto/src/xfer/dns_response.rs (+19 -19)
📝 crates/recursor/src/lib.rs (+1 -1)
📝 crates/recursor/src/recursor.rs (+3 -3)
📝 crates/resolver/src/cache.rs (+1 -1)
📝 crates/resolver/src/caching_client.rs (+2 -2)
📝 crates/server/src/authority/auth_lookup.rs (+41 -10)
📝 crates/server/src/authority/catalog.rs (+8 -9)
📝 crates/server/src/authority/message_request.rs (+11 -11)
📝 crates/server/src/authority/message_response.rs (+15 -15)
📝 crates/server/src/server/mod.rs (+1 -1)
📝 crates/server/src/store/in_memory/mod.rs (+4 -2)
📝 fuzz/fuzz_targets/message.rs (+1 -1)

...and 10 more files

📄 Description

This adds a field for the Authority section to AuthLookup::Records.

This is stacked on top of #3106 for now.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3107 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 7/10/2025 **Status:** ❌ Closed **Base:** `david/rename-authority-section` ← **Head:** `david/authlookup-authority-section` --- ### 📝 Commits (7) - [`3dbbbde`](https://github.com/hickory-dns/hickory-dns/commit/3dbbbde053d94a9ff747e28db99fccb6a2d1c476) Rename name_servers to authorities in Message, etc - [`d206d1b`](https://github.com/hickory-dns/hickory-dns/commit/d206d1baa53ff7af332245371bc07fea266ada6d) Revise Message method documentation - [`15a20ad`](https://github.com/hickory-dns/hickory-dns/commit/15a20ad705b951fc58c032888b2e691cbd1e7aae) Remove more unnecessary type annotations - [`f6e78f5`](https://github.com/hickory-dns/hickory-dns/commit/f6e78f512e308d6a31c478beeb156e9e870a17d3) Rename AuthLookup constructor method - [`faf4d3b`](https://github.com/hickory-dns/hickory-dns/commit/faf4d3bbb47b1337daa29292f73bc69ec98258fd) Use constructor method in more places - [`3378c58`](https://github.com/hickory-dns/hickory-dns/commit/3378c58c7658c5eeaefd01630f554c6b16a9975e) Add accessor to AuthLookup - [`7f41488`](https://github.com/hickory-dns/hickory-dns/commit/7f414885c085dd9d47b3f009fc36fa2541515ad2) Add Authority section to AuthLookup ### 📊 Changes **30 files changed** (+298 additions, -290 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/basic.rs` (+20 -38) 📝 `bin/tests/integration/in_memory.rs` (+6 -10) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+12 -12) 📝 `crates/proto/src/dnssec/rdata/tsig.rs` (+3 -3) 📝 `crates/proto/src/error.rs` (+3 -3) 📝 `crates/proto/src/op/header.rs` (+15 -15) 📝 `crates/proto/src/op/message.rs` (+84 -84) 📝 `crates/proto/src/op/update_message.rs` (+4 -4) 📝 `crates/proto/src/xfer/dns_response.rs` (+19 -19) 📝 `crates/recursor/src/lib.rs` (+1 -1) 📝 `crates/recursor/src/recursor.rs` (+3 -3) 📝 `crates/resolver/src/cache.rs` (+1 -1) 📝 `crates/resolver/src/caching_client.rs` (+2 -2) 📝 `crates/server/src/authority/auth_lookup.rs` (+41 -10) 📝 `crates/server/src/authority/catalog.rs` (+8 -9) 📝 `crates/server/src/authority/message_request.rs` (+11 -11) 📝 `crates/server/src/authority/message_response.rs` (+15 -15) 📝 `crates/server/src/server/mod.rs` (+1 -1) 📝 `crates/server/src/store/in_memory/mod.rs` (+4 -2) 📝 `fuzz/fuzz_targets/message.rs` (+1 -1) _...and 10 more files_ </details> ### 📄 Description This adds a field for the Authority section to `AuthLookup::Records`. This is stacked on top of #3106 for now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>