[PR #3086] [MERGED] server: use concrete type for authority lookups #3547

New issue

Closed

opened 2026-03-16 11:49:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:49:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3086
Author: @djc
Created: 6/25/2025
Status: ✅ Merged
Merged: 6/28/2025
Merged by: @djc

Base: main ← Head: server-lookup

📝 Commits (10+)

fa868d6 server: remove unnecessary alias
580eceb server: implement LookupObject for resolver::Lookup directly
ea00b97 server: use resolver Lookup directly in blocklist authority
402286b server: use resolver Lookup directly in recursor authority
fd6a2e9 server: use AuthLookup type for all authority impls
1482e2d server: drop associated Lookup type from Authority trait
65a7d0c server: use AuthLookup in AuthorityObject methods
5bb414a server: drop AuthorityObject trait in favor of using Authority directly
a1b2714 server: move DNSSEC summarization out of LookupObject
c17d3c9 server: remove unnecessary EmptyLookup type

📊 Changes

20 files changed (+269 additions, -782 deletions)

View changed files

📝 bin/src/dnssec.rs (+2 -2)
📝 bin/src/lib.rs (+7 -8)
📝 bin/tests/integration/authority_battery/basic.rs (+20 -20)
📝 bin/tests/integration/authority_battery/dnssec.rs (+11 -11)
📝 bin/tests/integration/authority_battery/dynamic_update.rs (+13 -27)
📝 bin/tests/integration/forwarder.rs (+1 -4)
📝 crates/server/Cargo.toml (+1 -1)
📝 crates/server/src/authority/auth_lookup.rs (+18 -28)
📝 crates/server/src/authority/authority.rs (+21 -45)
➖ crates/server/src/authority/authority_object.rs (+0 -418)
📝 crates/server/src/authority/catalog.rs (+60 -77)
📝 crates/server/src/authority/mod.rs (+42 -2)
📝 crates/server/src/store/blocklist.rs (+20 -38)
📝 crates/server/src/store/file.rs (+10 -10)
📝 crates/server/src/store/forwarder.rs (+8 -31)
📝 crates/server/src/store/in_memory/mod.rs (+5 -7)
📝 crates/server/src/store/metrics.rs (+2 -5)
📝 crates/server/src/store/recursor.rs (+6 -25)
📝 crates/server/src/store/sqlite/mod.rs (+6 -8)
📝 tests/integration-tests/tests/integration/chained_authority_tests.rs (+16 -15)

📄 Description

Removes all the trait object indirection/duplication in the server library API.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3086 **Author:** [@djc](https://github.com/djc) **Created:** 6/25/2025 **Status:** ✅ Merged **Merged:** 6/28/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `server-lookup` --- ### 📝 Commits (10+) - [`fa868d6`](https://github.com/hickory-dns/hickory-dns/commit/fa868d617d23db158727ac0d688b144b1f869148) server: remove unnecessary alias - [`580eceb`](https://github.com/hickory-dns/hickory-dns/commit/580ecebc470db5e654aebcf3bea5b2d06e32b65c) server: implement LookupObject for resolver::Lookup directly - [`ea00b97`](https://github.com/hickory-dns/hickory-dns/commit/ea00b97863920e1dbf3fa5b90edf68ec3844d66c) server: use resolver Lookup directly in blocklist authority - [`402286b`](https://github.com/hickory-dns/hickory-dns/commit/402286b6e8018194f5b872892b78b2f54e58c6f3) server: use resolver Lookup directly in recursor authority - [`fd6a2e9`](https://github.com/hickory-dns/hickory-dns/commit/fd6a2e9eaf06f6933843221634b835ba4bc48f44) server: use AuthLookup type for all authority impls - [`1482e2d`](https://github.com/hickory-dns/hickory-dns/commit/1482e2d6038a60f80f3a63755037b9369c09f1b5) server: drop associated Lookup type from Authority trait - [`65a7d0c`](https://github.com/hickory-dns/hickory-dns/commit/65a7d0cc6f948ec89695684055e8a5d87130953b) server: use AuthLookup in AuthorityObject methods - [`5bb414a`](https://github.com/hickory-dns/hickory-dns/commit/5bb414a289359ace45d6f3b45177d31f7e4b8cc2) server: drop AuthorityObject trait in favor of using Authority directly - [`a1b2714`](https://github.com/hickory-dns/hickory-dns/commit/a1b2714ffa9ed6bbe3fe00444cb2e2b44ef2e384) server: move DNSSEC summarization out of LookupObject - [`c17d3c9`](https://github.com/hickory-dns/hickory-dns/commit/c17d3c9ebbc80bac55e925d901e428187c19c65d) server: remove unnecessary EmptyLookup type ### 📊 Changes **20 files changed** (+269 additions, -782 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/dnssec.rs` (+2 -2) 📝 `bin/src/lib.rs` (+7 -8) 📝 `bin/tests/integration/authority_battery/basic.rs` (+20 -20) 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+11 -11) 📝 `bin/tests/integration/authority_battery/dynamic_update.rs` (+13 -27) 📝 `bin/tests/integration/forwarder.rs` (+1 -4) 📝 `crates/server/Cargo.toml` (+1 -1) 📝 `crates/server/src/authority/auth_lookup.rs` (+18 -28) 📝 `crates/server/src/authority/authority.rs` (+21 -45) ➖ `crates/server/src/authority/authority_object.rs` (+0 -418) 📝 `crates/server/src/authority/catalog.rs` (+60 -77) 📝 `crates/server/src/authority/mod.rs` (+42 -2) 📝 `crates/server/src/store/blocklist.rs` (+20 -38) 📝 `crates/server/src/store/file.rs` (+10 -10) 📝 `crates/server/src/store/forwarder.rs` (+8 -31) 📝 `crates/server/src/store/in_memory/mod.rs` (+5 -7) 📝 `crates/server/src/store/metrics.rs` (+2 -5) 📝 `crates/server/src/store/recursor.rs` (+6 -25) 📝 `crates/server/src/store/sqlite/mod.rs` (+6 -8) 📝 `tests/integration-tests/tests/integration/chained_authority_tests.rs` (+16 -15) </details> ### 📄 Description Removes all the trait object indirection/duplication in the server library API. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>