[PR #3062] [MERGED] server/authority: simplify Catalog::update req verify #3531

New issue

Closed

opened 2026-03-16 11:48:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:48:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3062
Author: @cpu
Created: 6/17/2025
Status: ✅ Merged
Merged: 6/17/2025
Merged by: @djc

Base: main ← Head: cpu-simplify-update-verify_dev

📝 Commits (1)

b21b7b2 server/authority: simplify Catalog::update req verify

📊 Changes

1 file changed (+12 additions, -24 deletions)

View changed files

📝 crates/server/src/authority/catalog.rs (+12 -24)

📄 Description

Previously some request verification logic was bundled into a closure, but since it's only called in one place, and the err result wasn't used, this seems unnecessarily complex. Am I overlooking anything?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3062 **Author:** [@cpu](https://github.com/cpu) **Created:** 6/17/2025 **Status:** ✅ Merged **Merged:** 6/17/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `cpu-simplify-update-verify_dev` --- ### 📝 Commits (1) - [`b21b7b2`](https://github.com/hickory-dns/hickory-dns/commit/b21b7b227f96982fb99a6edcba458ce7117dac53) server/authority: simplify Catalog::update req verify ### 📊 Changes **1 file changed** (+12 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/authority/catalog.rs` (+12 -24) </details> ### 📄 Description Previously some request verification logic was bundled into a closure, but since it's only called in one place, and the err result wasn't used, this seems unnecessarily complex. Am I overlooking anything? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>