[PR #3044] [MERGED] server: blocklist tweaks #3517

New issue

Closed

opened 2026-03-16 11:47:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:47:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3044
Author: @djc
Created: 6/12/2025
Status: ✅ Merged
Merged: 6/13/2025
Merged by: @divergentdave

Base: main ← Head: blocklist-tweaks

📝 Commits (10+)

b0c259a proto: import DerefMut for LowerName
54ec26a server: avoid allocating intermediate value
1b97333 server: flatten blocklist entry validation
b469d32 server: avoid logging error before reraising
bfa675a server: use WARN log level for non-fatal errors
24fa79e server: import parent items in tests module
df93cbe server: move TestResult enum down
065a6d1 Clean up more uses of ref keyword
87bc318 server: make BlockListAuthority::try_from_config() synchronous
7c08016 server: deduplicate blocklist authority test setup

📊 Changes

7 files changed (+121 additions, -204 deletions)

View changed files

📝 bin/src/dnssec.rs (+22 -0)
📝 bin/src/lib.rs (+9 -46)
📝 conformance/packages/dns-test/src/container.rs (+1 -1)
📝 crates/client/src/client/rc_stream.rs (+2 -2)
📝 crates/proto/src/dnssec/mod.rs (+1 -1)
📝 crates/proto/src/rr/lower_name.rs (+7 -1)
📝 crates/server/src/store/blocklist.rs (+79 -153)

📄 Description

Followup from #3035.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3044 **Author:** [@djc](https://github.com/djc) **Created:** 6/12/2025 **Status:** ✅ Merged **Merged:** 6/13/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `blocklist-tweaks` --- ### 📝 Commits (10+) - [`b0c259a`](https://github.com/hickory-dns/hickory-dns/commit/b0c259afabb507b939ff60344aecedabe5790c17) proto: import DerefMut for LowerName - [`54ec26a`](https://github.com/hickory-dns/hickory-dns/commit/54ec26a78c608ff5eacf6af56a613c4efc03a88d) server: avoid allocating intermediate value - [`1b97333`](https://github.com/hickory-dns/hickory-dns/commit/1b97333c566fcfef5a6596feeb4ce48a349986a5) server: flatten blocklist entry validation - [`b469d32`](https://github.com/hickory-dns/hickory-dns/commit/b469d32226187237daf5246dcd1bc7e4a74feed4) server: avoid logging error before reraising - [`bfa675a`](https://github.com/hickory-dns/hickory-dns/commit/bfa675a8b708ffeae1965d78ed7a26abcbe45308) server: use WARN log level for non-fatal errors - [`24fa79e`](https://github.com/hickory-dns/hickory-dns/commit/24fa79ecb506c177ec8fb742209c2408b963073d) server: import parent items in tests module - [`df93cbe`](https://github.com/hickory-dns/hickory-dns/commit/df93cbe37669f51c277fca0f049f7fc801034e36) server: move TestResult enum down - [`065a6d1`](https://github.com/hickory-dns/hickory-dns/commit/065a6d1279a336fa306391cdccb7d86d58bfff1e) Clean up more uses of ref keyword - [`87bc318`](https://github.com/hickory-dns/hickory-dns/commit/87bc318cc82ffb727b8e0852b834c35fb4a27b12) server: make BlockListAuthority::try_from_config() synchronous - [`7c08016`](https://github.com/hickory-dns/hickory-dns/commit/7c08016537696b2094f099a2869d71cb4f895f91) server: deduplicate blocklist authority test setup ### 📊 Changes **7 files changed** (+121 additions, -204 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/dnssec.rs` (+22 -0) 📝 `bin/src/lib.rs` (+9 -46) 📝 `conformance/packages/dns-test/src/container.rs` (+1 -1) 📝 `crates/client/src/client/rc_stream.rs` (+2 -2) 📝 `crates/proto/src/dnssec/mod.rs` (+1 -1) 📝 `crates/proto/src/rr/lower_name.rs` (+7 -1) 📝 `crates/server/src/store/blocklist.rs` (+79 -153) </details> ### 📄 Description Followup from #3035. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>