[PR #3030] [MERGED] Add metrics for zone lookups, DNS classes and record types #3509

Closed
opened 2026-03-16 11:47:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3030
Author: @hargut
Created: 6/4/2025
Status: Merged
Merged: 7/8/2025
Merged by: @divergentdave

Base: mainHead: feat/add-zone-lookup-dns-class-record-type-metrics


📝 Commits (3)

  • e5ab2e6 server: add request / response metrics
  • ec1deee server: add zone lookup metrics
  • f91e569 server: remove query store metrics

📊 Changes

15 files changed (+565 additions, -140 deletions)

View changed files

📝 bin/tests/integration/named_metrics_tests.rs (+149 -30)
📝 crates/server/src/authority/authority.rs (+4 -0)
📝 crates/server/src/authority/catalog.rs (+21 -0)
crates/server/src/authority/metrics.rs (+326 -0)
📝 crates/server/src/authority/mod.rs (+3 -1)
📝 crates/server/src/store/blocklist.rs (+5 -0)
📝 crates/server/src/store/file.rs (+14 -18)
📝 crates/server/src/store/forwarder.rs (+7 -13)
📝 crates/server/src/store/in_memory/mod.rs (+5 -0)
📝 crates/server/src/store/metrics.rs (+3 -58)
📝 crates/server/src/store/recursor.rs (+5 -0)
📝 crates/server/src/store/sqlite/mod.rs (+16 -19)
📝 tests/integration-tests/Cargo.toml (+1 -0)
📝 tests/integration-tests/tests/integration/chained_authority_tests.rs (+5 -0)
📝 tests/test-data/test_configs/example_forwarder.toml (+1 -1)

📄 Description

The PR adds metrics covering the following areas:

  • zone (authority) lookups
  • request/response DNS classes
  • request/response DNS record types (#3007)

Kind regdards,
Harald


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3030 **Author:** [@hargut](https://github.com/hargut) **Created:** 6/4/2025 **Status:** ✅ Merged **Merged:** 7/8/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `feat/add-zone-lookup-dns-class-record-type-metrics` --- ### 📝 Commits (3) - [`e5ab2e6`](https://github.com/hickory-dns/hickory-dns/commit/e5ab2e6665a25486e923141d9b975e30c759b7eb) server: add request / response metrics - [`ec1deee`](https://github.com/hickory-dns/hickory-dns/commit/ec1deee5311464bedc158e5d2ae80a1cb3253b7d) server: add zone lookup metrics - [`f91e569`](https://github.com/hickory-dns/hickory-dns/commit/f91e5694e9860131fcd58517db7c0408b5b6770d) server: remove query store metrics ### 📊 Changes **15 files changed** (+565 additions, -140 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/named_metrics_tests.rs` (+149 -30) 📝 `crates/server/src/authority/authority.rs` (+4 -0) 📝 `crates/server/src/authority/catalog.rs` (+21 -0) ➕ `crates/server/src/authority/metrics.rs` (+326 -0) 📝 `crates/server/src/authority/mod.rs` (+3 -1) 📝 `crates/server/src/store/blocklist.rs` (+5 -0) 📝 `crates/server/src/store/file.rs` (+14 -18) 📝 `crates/server/src/store/forwarder.rs` (+7 -13) 📝 `crates/server/src/store/in_memory/mod.rs` (+5 -0) 📝 `crates/server/src/store/metrics.rs` (+3 -58) 📝 `crates/server/src/store/recursor.rs` (+5 -0) 📝 `crates/server/src/store/sqlite/mod.rs` (+16 -19) 📝 `tests/integration-tests/Cargo.toml` (+1 -0) 📝 `tests/integration-tests/tests/integration/chained_authority_tests.rs` (+5 -0) 📝 `tests/test-data/test_configs/example_forwarder.toml` (+1 -1) </details> ### 📄 Description The PR adds metrics covering the following areas: - zone (authority) lookups - request/response DNS classes - request/response DNS record types (#3007) Kind regdards, Harald --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:47:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3509
No description provided.