[PR #3032] [MERGED] resolver: clean up Windows-only warnings #3506

New issue

Closed

opened 2026-03-16 11:47:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:47:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3032
Author: @djc
Created: 6/6/2025
Status: ✅ Merged
Merged: 6/6/2025
Merged by: @djc

Base: main ← Head: windows-warnings

📝 Commits (3)

3f4baff resolver: clean up Windows-only warnings
eab96fe resolver: inline get_name_servers()
296dbe9 resolver: tweak style in windows::read_system_conf()

📊 Changes

2 files changed (+27 additions, -31 deletions)

View changed files

📝 crates/resolver/src/resolver.rs (+6 -5)
📝 crates/resolver/src/system_conf/windows.rs (+21 -26)

📄 Description

Plus assorted style tweaks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3032 **Author:** [@djc](https://github.com/djc) **Created:** 6/6/2025 **Status:** ✅ Merged **Merged:** 6/6/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `windows-warnings` --- ### 📝 Commits (3) - [`3f4baff`](https://github.com/hickory-dns/hickory-dns/commit/3f4baffef49c3d521325eb15c3ea1e39e97f8899) resolver: clean up Windows-only warnings - [`eab96fe`](https://github.com/hickory-dns/hickory-dns/commit/eab96fe4e449012dd47517777d3097e5da2722ad) resolver: inline get_name_servers() - [`296dbe9`](https://github.com/hickory-dns/hickory-dns/commit/296dbe98a5925338e33572588b4f3c2864f5045a) resolver: tweak style in windows::read_system_conf() ### 📊 Changes **2 files changed** (+27 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/resolver.rs` (+6 -5) 📝 `crates/resolver/src/system_conf/windows.rs` (+21 -26) </details> ### 📄 Description Plus assorted style tweaks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>