[PR #3016] [MERGED] Require explicit message metadata #3492

New issue

Closed

opened 2026-03-16 11:46:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:46:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3016
Author: @djc
Created: 5/26/2025
Status: ✅ Merged
Merged: 5/28/2025
Merged by: @djc

Base: main ← Head: message-types

📝 Commits (10+)

953a5de proto: keep Header definition close to inherent impl
3c75d45 proto: wrap tests in tests module
aa76902 proto: discard Message::query() method
b65027c proto: remove Default impls for Header and Message
0f59131 proto: rename Message::new() to query()
644fe22 server: preserve Header for ResponseInfo
f6d96c8 server: use structured logging for errors
9894f82 server: maintain request ID in ResponseInfo
c4cd1cd proto: require input for Header::new()
c4c0636 proto: discard Message::set_message_type() method

📊 Changes

48 files changed (+450 additions, -533 deletions)

View changed files

📝 bin/tests/integration/authority_battery/basic.rs (+4 -4)
📝 bin/tests/integration/authority_battery/dnssec.rs (+3 -4)
📝 bin/tests/integration/authority_battery/dynamic_update.rs (+2 -2)
📝 crates/client/src/client/client.rs (+3 -7)
📝 crates/client/src/client/memoize_client_handle.rs (+6 -13)
📝 crates/proto/benches/lib.rs (+5 -14)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+1 -1)
📝 crates/proto/src/dnssec/rdata/tsig.rs (+2 -2)
📝 crates/proto/src/dnssec/signer.rs (+1 -1)
📝 crates/proto/src/dnssec/tsig.rs (+2 -2)
📝 crates/proto/src/h2/h2_client_stream.rs (+6 -6)
📝 crates/proto/src/h2/h2_server.rs (+1 -1)
📝 crates/proto/src/h3/h3_client_stream.rs (+7 -7)
📝 crates/proto/src/op/header.rs (+153 -155)
📝 crates/proto/src/op/message.rs (+52 -55)
📝 crates/proto/src/op/update_message.rs (+9 -25)
📝 crates/proto/src/quic/tests.rs (+2 -1)
📝 crates/proto/src/serialize/binary/encoder.rs (+10 -4)
📝 crates/proto/src/tests/udp.rs (+2 -2)
📝 crates/proto/src/udp/udp_client_stream.rs (+0 -10)

...and 28 more files

📄 Description

As suggested in #3010. More to come, but this seems like a decent start.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3016 **Author:** [@djc](https://github.com/djc) **Created:** 5/26/2025 **Status:** ✅ Merged **Merged:** 5/28/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `message-types` --- ### 📝 Commits (10+) - [`953a5de`](https://github.com/hickory-dns/hickory-dns/commit/953a5de15a0789745cb7f0e90a0ab9a5f82662ed) proto: keep Header definition close to inherent impl - [`3c75d45`](https://github.com/hickory-dns/hickory-dns/commit/3c75d455df4ea2678c810e1ae925aa40c6ffa14d) proto: wrap tests in tests module - [`aa76902`](https://github.com/hickory-dns/hickory-dns/commit/aa76902bc973234ef210f75b2ec1647b0f3bc2ee) proto: discard Message::query() method - [`b65027c`](https://github.com/hickory-dns/hickory-dns/commit/b65027c2e988eb4fa17300b63f7f344e2c7cbf8a) proto: remove Default impls for Header and Message - [`0f59131`](https://github.com/hickory-dns/hickory-dns/commit/0f59131b4de772026a455910f8e622672eedb307) proto: rename Message::new() to query() - [`644fe22`](https://github.com/hickory-dns/hickory-dns/commit/644fe22997420ffa277f904f0d24d3c76f901c2f) server: preserve Header for ResponseInfo - [`f6d96c8`](https://github.com/hickory-dns/hickory-dns/commit/f6d96c8c3253f8b492d8fdfa3ae2d6841a0ca992) server: use structured logging for errors - [`9894f82`](https://github.com/hickory-dns/hickory-dns/commit/9894f82e83fa5c3ae76a69e72ff6fed753f2886e) server: maintain request ID in ResponseInfo - [`c4cd1cd`](https://github.com/hickory-dns/hickory-dns/commit/c4cd1cd4baf935d07eb1a21e0995c605d4071968) proto: require input for Header::new() - [`c4c0636`](https://github.com/hickory-dns/hickory-dns/commit/c4c0636e571bf54478b41c16d96875193318240e) proto: discard Message::set_message_type() method ### 📊 Changes **48 files changed** (+450 additions, -533 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/basic.rs` (+4 -4) 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+3 -4) 📝 `bin/tests/integration/authority_battery/dynamic_update.rs` (+2 -2) 📝 `crates/client/src/client/client.rs` (+3 -7) 📝 `crates/client/src/client/memoize_client_handle.rs` (+6 -13) 📝 `crates/proto/benches/lib.rs` (+5 -14) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+1 -1) 📝 `crates/proto/src/dnssec/rdata/tsig.rs` (+2 -2) 📝 `crates/proto/src/dnssec/signer.rs` (+1 -1) 📝 `crates/proto/src/dnssec/tsig.rs` (+2 -2) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+6 -6) 📝 `crates/proto/src/h2/h2_server.rs` (+1 -1) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+7 -7) 📝 `crates/proto/src/op/header.rs` (+153 -155) 📝 `crates/proto/src/op/message.rs` (+52 -55) 📝 `crates/proto/src/op/update_message.rs` (+9 -25) 📝 `crates/proto/src/quic/tests.rs` (+2 -1) 📝 `crates/proto/src/serialize/binary/encoder.rs` (+10 -4) 📝 `crates/proto/src/tests/udp.rs` (+2 -2) 📝 `crates/proto/src/udp/udp_client_stream.rs` (+0 -10) _...and 28 more files_ </details> ### 📄 Description As suggested in #3010. More to come, but this seems like a decent start. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>