[PR #3000] [MERGED] Avoid large errors #3480

New issue

Closed

opened 2026-03-16 11:46:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:46:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3000
Author: @djc
Created: 5/20/2025
Status: ✅ Merged
Merged: 5/20/2025
Merged by: @djc

Base: main ← Head: large-errors

📝 Commits (2)

7801018 proto: box ProofError::kind to shrink error type
913dd44 proto: replace RData::try_from_rdata() with Record::map()

📊 Changes

36 files changed (+49 additions, -275 deletions)

View changed files

📝 bin/tests/integration/authority_battery/dnssec.rs (+14 -7)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+14 -20)
📝 crates/proto/src/dnssec/proof.rs (+7 -3)
📝 crates/proto/src/dnssec/rdata/cdnskey.rs (+0 -7)
📝 crates/proto/src/dnssec/rdata/cds.rs (+0 -7)
📝 crates/proto/src/dnssec/rdata/dnskey.rs (+0 -7)
📝 crates/proto/src/dnssec/rdata/ds.rs (+0 -7)
📝 crates/proto/src/dnssec/rdata/key.rs (+0 -7)
📝 crates/proto/src/dnssec/rdata/nsec.rs (+0 -7)
📝 crates/proto/src/dnssec/rdata/nsec3.rs (+0 -7)
📝 crates/proto/src/dnssec/rdata/nsec3param.rs (+0 -7)
📝 crates/proto/src/dnssec/rdata/rrsig.rs (+0 -7)
📝 crates/proto/src/dnssec/rdata/sig.rs (+0 -7)
📝 crates/proto/src/dnssec/rdata/tsig.rs (+0 -7)
📝 crates/proto/src/rr/mod.rs (+0 -4)
📝 crates/proto/src/rr/rdata/a.rs (+0 -7)
📝 crates/proto/src/rr/rdata/aaaa.rs (+0 -7)
📝 crates/proto/src/rr/rdata/caa.rs (+0 -7)
📝 crates/proto/src/rr/rdata/cert.rs (+0 -7)
📝 crates/proto/src/rr/rdata/csync.rs (+0 -7)

...and 16 more files

📄 Description

See #2994.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3000 **Author:** [@djc](https://github.com/djc) **Created:** 5/20/2025 **Status:** ✅ Merged **Merged:** 5/20/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `large-errors` --- ### 📝 Commits (2) - [`7801018`](https://github.com/hickory-dns/hickory-dns/commit/780101859bbfc2943eae40506c1b1d819455e93b) proto: box ProofError::kind to shrink error type - [`913dd44`](https://github.com/hickory-dns/hickory-dns/commit/913dd44aa70d5f6988dee7c1b697ac8bda1a71cd) proto: replace RData::try_from_rdata() with Record::map() ### 📊 Changes **36 files changed** (+49 additions, -275 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+14 -7) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+14 -20) 📝 `crates/proto/src/dnssec/proof.rs` (+7 -3) 📝 `crates/proto/src/dnssec/rdata/cdnskey.rs` (+0 -7) 📝 `crates/proto/src/dnssec/rdata/cds.rs` (+0 -7) 📝 `crates/proto/src/dnssec/rdata/dnskey.rs` (+0 -7) 📝 `crates/proto/src/dnssec/rdata/ds.rs` (+0 -7) 📝 `crates/proto/src/dnssec/rdata/key.rs` (+0 -7) 📝 `crates/proto/src/dnssec/rdata/nsec.rs` (+0 -7) 📝 `crates/proto/src/dnssec/rdata/nsec3.rs` (+0 -7) 📝 `crates/proto/src/dnssec/rdata/nsec3param.rs` (+0 -7) 📝 `crates/proto/src/dnssec/rdata/rrsig.rs` (+0 -7) 📝 `crates/proto/src/dnssec/rdata/sig.rs` (+0 -7) 📝 `crates/proto/src/dnssec/rdata/tsig.rs` (+0 -7) 📝 `crates/proto/src/rr/mod.rs` (+0 -4) 📝 `crates/proto/src/rr/rdata/a.rs` (+0 -7) 📝 `crates/proto/src/rr/rdata/aaaa.rs` (+0 -7) 📝 `crates/proto/src/rr/rdata/caa.rs` (+0 -7) 📝 `crates/proto/src/rr/rdata/cert.rs` (+0 -7) 📝 `crates/proto/src/rr/rdata/csync.rs` (+0 -7) _...and 16 more files_ </details> ### 📄 Description See #2994. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>