[PR #2993] [MERGED] Fix Clippy lints #3476

Closed
opened 2026-03-16 11:45:48 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2993
Author: @divergentdave
Created: 5/15/2025
Status: Merged
Merged: 5/15/2025
Merged by: @djc

Base: mainHead: david/clippy


📝 Commits (2)

  • d60d7c3 Fix Clippy lint
  • 7a18d7d Ignore Clippy lints for large enum variants

📊 Changes

3 files changed (+7 additions, -5 deletions)

View changed files

📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+2 -0)
📝 crates/proto/src/xfer/dns_exchange.rs (+1 -0)
📝 crates/server/src/store/in_memory/inner.rs (+4 -5)

📄 Description

This fixes and ignores Clippy lints that show up with a 1.87 toolchain. This adds more ignores of clippy::large_enum_variant and clippy::result_large_err, which we have a few of already.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2993 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 5/15/2025 **Status:** ✅ Merged **Merged:** 5/15/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/clippy` --- ### 📝 Commits (2) - [`d60d7c3`](https://github.com/hickory-dns/hickory-dns/commit/d60d7c3f4a8319b6a7a02b6023e8ad11d9c11c5f) Fix Clippy lint - [`7a18d7d`](https://github.com/hickory-dns/hickory-dns/commit/7a18d7d64d8a32056fd5d9b3614efab3b76cc0d7) Ignore Clippy lints for large enum variants ### 📊 Changes **3 files changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+2 -0) 📝 `crates/proto/src/xfer/dns_exchange.rs` (+1 -0) 📝 `crates/server/src/store/in_memory/inner.rs` (+4 -5) </details> ### 📄 Description This fixes and ignores Clippy lints that show up with a 1.87 toolchain. This adds more ignores of `clippy::large_enum_variant` and `clippy::result_large_err`, which we have a few of already. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:45:48 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3476
No description provided.