[PR #2980] [MERGED] Don't request root DS RRset in find_ds_records() #3466

New issue

Closed

opened 2026-03-16 11:45:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:45:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2980
Author: @divergentdave
Created: 5/8/2025
Status: ✅ Merged
Merged: 5/9/2025
Merged by: @divergentdave

Base: main ← Head: david/skip-root-ds-query

📝 Commits (2)

ff9ad1b Don't request root DS RRset in find_ds_records()
1f4a3b4 Add conformance test

📊 Changes

2 files changed (+71 additions, -6 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/secure.rs (+67 -2)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+4 -4)

📄 Description

This is a follow-up to the refactoring of find_ds_records(). The query . IN DS is not well-formed, since such DS records would need to live at the parent of the root zone, so we can stop this loop one iteration earlier.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2980 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 5/8/2025 **Status:** ✅ Merged **Merged:** 5/9/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/skip-root-ds-query` --- ### 📝 Commits (2) - [`ff9ad1b`](https://github.com/hickory-dns/hickory-dns/commit/ff9ad1b8e63b7131c88e1261f1bc94c647630bf0) Don't request root DS RRset in find_ds_records() - [`1f4a3b4`](https://github.com/hickory-dns/hickory-dns/commit/1f4a3b44689ecc024ac7eddbe10c532326522634) Add conformance test ### 📊 Changes **2 files changed** (+71 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/secure.rs` (+67 -2) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+4 -4) </details> ### 📄 Description This is a follow-up to the refactoring of `find_ds_records()`. The query `. IN DS` is not well-formed, since such DS records would need to live at the parent of the root zone, so we can stop this loop one iteration earlier. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>