[PR #2970] [MERGED] resolver: remove unnecessary ResolveError wrapper #3456

New issue

Closed

opened 2026-03-16 11:44:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:44:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2970
Author: @djc
Created: 5/6/2025
Status: ✅ Merged
Merged: 5/8/2025
Merged by: @djc

Base: main ← Head: kill-resolve-error

📝 Commits (2)

5f9a028 resolver: remove unnecessary ResolveError wrapper
813cdec util: simplify print_error()

📊 Changes

13 files changed (+103 additions, -367 deletions)

View changed files

📝 crates/recursor/src/error.rs (+17 -43)
📝 crates/recursor/src/recursor.rs (+1 -5)
📝 crates/recursor/src/recursor_pool.rs (+11 -12)
📝 crates/resolver/src/caching_client.rs (+9 -14)
➖ crates/resolver/src/error.rs (+0 -197)
📝 crates/resolver/src/lib.rs (+0 -2)
📝 crates/resolver/src/lookup_ip.rs (+12 -14)
📝 crates/resolver/src/resolver.rs (+16 -25)
📝 crates/resolver/src/system_conf/unix.rs (+5 -7)
📝 crates/resolver/src/system_conf/windows.rs (+11 -10)
📝 crates/server/src/authority/mod.rs (+3 -12)
📝 tests/integration-tests/tests/integration/lookup_tests.rs (+0 -10)
📝 util/src/bin/resolve.rs (+18 -16)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2970 **Author:** [@djc](https://github.com/djc) **Created:** 5/6/2025 **Status:** ✅ Merged **Merged:** 5/8/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `kill-resolve-error` --- ### 📝 Commits (2) - [`5f9a028`](https://github.com/hickory-dns/hickory-dns/commit/5f9a028545fb5c6a580ead7b1ae93a0aa3bc7fd4) resolver: remove unnecessary ResolveError wrapper - [`813cdec`](https://github.com/hickory-dns/hickory-dns/commit/813cdece574f489e0b55569d8446b9cf67281627) util: simplify print_error() ### 📊 Changes **13 files changed** (+103 additions, -367 deletions) <details> <summary>View changed files</summary> 📝 `crates/recursor/src/error.rs` (+17 -43) 📝 `crates/recursor/src/recursor.rs` (+1 -5) 📝 `crates/recursor/src/recursor_pool.rs` (+11 -12) 📝 `crates/resolver/src/caching_client.rs` (+9 -14) ➖ `crates/resolver/src/error.rs` (+0 -197) 📝 `crates/resolver/src/lib.rs` (+0 -2) 📝 `crates/resolver/src/lookup_ip.rs` (+12 -14) 📝 `crates/resolver/src/resolver.rs` (+16 -25) 📝 `crates/resolver/src/system_conf/unix.rs` (+5 -7) 📝 `crates/resolver/src/system_conf/windows.rs` (+11 -10) 📝 `crates/server/src/authority/mod.rs` (+3 -12) 📝 `tests/integration-tests/tests/integration/lookup_tests.rs` (+0 -10) 📝 `util/src/bin/resolve.rs` (+18 -16) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>