[PR #2946] [MERGED] hickory-resolver: Allow compiling with quic support but without ring #3442

New issue

Closed

opened 2026-03-16 11:43:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:43:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2946
Author: @msrd0
Created: 4/24/2025
Status: ✅ Merged
Merged: 4/24/2025
Merged by: @divergentdave

Base: main ← Head: quic-without-ring

📝 Commits (1)

fbced4e hickory-resolver: allow compiling with quic support but without ring

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 crates/resolver/Cargo.toml (+2 -3)

📄 Description

Enabling quinn/rustls is equivalent to enabling quinn/rustls-ring which means we can never enable quic support if we want to only use aws-lc-rs. Therefore we need to enable quinn/rustls-ring or quinn/rustls-aws-lc-rs depending on the feature selected.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2946 **Author:** [@msrd0](https://github.com/msrd0) **Created:** 4/24/2025 **Status:** ✅ Merged **Merged:** 4/24/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `quic-without-ring` --- ### 📝 Commits (1) - [`fbced4e`](https://github.com/hickory-dns/hickory-dns/commit/fbced4e4f667050def068929d982bd0d5998a80d) hickory-resolver: allow compiling with quic support but without ring ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/Cargo.toml` (+2 -3) </details> ### 📄 Description Enabling `quinn/rustls` is equivalent to enabling `quinn/rustls-ring` which means we can never enable quic support if we want to only use `aws-lc-rs`. Therefore we need to enable `quinn/rustls-ring` or `quinn/rustls-aws-lc-rs` depending on the feature selected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>