[PR #2920] [MERGED] Use wait_until() in a second conformance test #3429

New issue

Closed

opened 2026-03-16 11:43:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:43:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2920
Author: @divergentdave
Created: 4/10/2025
Status: ✅ Merged
Merged: 4/10/2025
Merged by: @divergentdave

Base: main ← Head: david/conformance-use-wait-until

📝 Commits (5)

8228d60 Use wait_until() in a second conformance test
82ca373 Reduce rightward drift when destructuring capture
bfa4672 Reduce rightward drift when checking destination
a7e4949 Hoist stringified domain variable
8177b1e Reduce rightward drift in loop over queries

📊 Changes

1 file changed (+35 additions, -28 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_1/section_3_1_4.rs (+35 -28)

📄 Description

I noticed this test flaking in CI a couple times recently. Perhaps #2868 made the race condition tighter? This PR rewrites the tshark-related assertion to use the new wait_until() method, so we won't proceed until we see the expected packet, and not just any packet.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2920 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 4/10/2025 **Status:** ✅ Merged **Merged:** 4/10/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/conformance-use-wait-until` --- ### 📝 Commits (5) - [`8228d60`](https://github.com/hickory-dns/hickory-dns/commit/8228d608f468d5a42730b2942786e6571e771ded) Use wait_until() in a second conformance test - [`82ca373`](https://github.com/hickory-dns/hickory-dns/commit/82ca37343faf23927575f2401af5534b81df66d2) Reduce rightward drift when destructuring capture - [`bfa4672`](https://github.com/hickory-dns/hickory-dns/commit/bfa46722d00dea7ae4a45361840d93ba70b0942e) Reduce rightward drift when checking destination - [`a7e4949`](https://github.com/hickory-dns/hickory-dns/commit/a7e4949ef8675ffb1b86950ac1915be28044aa64) Hoist stringified domain variable - [`8177b1e`](https://github.com/hickory-dns/hickory-dns/commit/8177b1ec689b6436a7752240ffcc5f1a386f7d7b) Reduce rightward drift in loop over queries ### 📊 Changes **1 file changed** (+35 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_1/section_3_1_4.rs` (+35 -28) </details> ### 📄 Description I noticed this test flaking in CI a couple times recently. Perhaps #2868 made the race condition tighter? This PR rewrites the tshark-related assertion to use the new `wait_until()` method, so we won't proceed until we see the expected packet, and not just any packet. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>