[PR #2896] [MERGED] proto: drop pointers from rolled back records #3407

New issue

Closed

opened 2026-03-16 11:42:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:42:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2896
Author: @djc
Created: 3/31/2025
Status: ✅ Merged
Merged: 3/31/2025
Merged by: @djc

Base: main ← Head: prior-to-pointer

📝 Commits (4)

40d4eab proto: reorder items to keep impls together
81e9cac proto: drop unnecessary type annotation
54ede44 proto: unpack some combinators
e449731 proto: drop pointers from rolled back records

📊 Changes

3 files changed (+98 additions, -83 deletions)

View changed files

📝 crates/proto/src/op/message.rs (+80 -72)
📝 crates/proto/src/serialize/binary/encoder.rs (+18 -11)
➕ crates/proto/tests/test-data/fuzz-prior-to-pointer.rdata (+0 -0)

📄 Description

This should fix the fuzzer issue from https://issues.oss-fuzz.com/issues/404925372 (details).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2896 **Author:** [@djc](https://github.com/djc) **Created:** 3/31/2025 **Status:** ✅ Merged **Merged:** 3/31/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `prior-to-pointer` --- ### 📝 Commits (4) - [`40d4eab`](https://github.com/hickory-dns/hickory-dns/commit/40d4eabb5ea4b3808490a0bcbfd3f4e5947cd4a9) proto: reorder items to keep impls together - [`81e9cac`](https://github.com/hickory-dns/hickory-dns/commit/81e9cac2d1c9060b5bd7aa3acef9bc8e60b934b4) proto: drop unnecessary type annotation - [`54ede44`](https://github.com/hickory-dns/hickory-dns/commit/54ede441d4c653e03e95315dee1baa798271d326) proto: unpack some combinators - [`e449731`](https://github.com/hickory-dns/hickory-dns/commit/e44973154133213379c38b5e8101aed23678d4cb) proto: drop pointers from rolled back records ### 📊 Changes **3 files changed** (+98 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/message.rs` (+80 -72) 📝 `crates/proto/src/serialize/binary/encoder.rs` (+18 -11) ➕ `crates/proto/tests/test-data/fuzz-prior-to-pointer.rdata` (+0 -0) </details> ### 📄 Description This should fix the fuzzer issue from https://issues.oss-fuzz.com/issues/404925372 ([details](https://oss-fuzz.com/testcase-detail/5270561572061184)). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>