[PR #2883] [CLOSED] Deduplicate NSEC3 records in response #3399

New issue

Closed

opened 2026-03-16 11:41:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:41:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2883
Author: @divergentdave
Created: 3/24/2025
Status: ❌ Closed

Base: main ← Head: david/deduplicate-nsec3

📝 Commits (1)

496b049 Deduplicate NSEC3 records in response

📊 Changes

1 file changed (+12 additions, -5 deletions)

View changed files

📝 crates/server/src/store/in_memory/authority.rs (+12 -5)

📄 Description

This closes #2811. If one NSEC3 record is needed for two purposes, this will only add it to the response once. Note that the relevant tests are still failing for unrelated reasons.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2883 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 3/24/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `david/deduplicate-nsec3` --- ### 📝 Commits (1) - [`496b049`](https://github.com/hickory-dns/hickory-dns/commit/496b049542b16cb2761051c738f66dadf585342a) Deduplicate NSEC3 records in response ### 📊 Changes **1 file changed** (+12 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/store/in_memory/authority.rs` (+12 -5) </details> ### 📄 Description This closes #2811. If one NSEC3 record is needed for two purposes, this will only add it to the response once. Note that the relevant tests are still failing for unrelated reasons. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>