[PR #2885] [MERGED] Refactor in-memory authority DNSSEC handling #3395

New issue

Closed

opened 2026-03-16 11:41:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:41:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2885
Author: @djc
Created: 3/25/2025
Status: ✅ Merged
Merged: 3/25/2025
Merged by: @djc

Base: main ← Head: authority-tweaks

📝 Commits (10+)

2813867 server: extract closure into method
8ba8220 server: move InMemoryAuthority impls closer to type definition
18928a3 server: remove get_() prefix from private method
ed3c178 server: reduce rightward drift in InnerInMemory::proof()
70eaa22 server: reduce rightward drift in InnerInMemory::proof() more
1d5fa22 server: simplify wildcard match handling
4883d03 server: further linearize InnerInMemory::proof()
9dec262 server: deduplicate NSEC3 records in response
92faf1f server: remove module indirection
70c3b2c server: move InnerInMemory into a separate module

📊 Changes

5 files changed (+1746 additions, -1668 deletions)

View changed files

📝 bin/tests/integration/authority_battery/basic.rs (+38 -0)
📝 bin/tests/integration/authority_battery/dnssec.rs (+38 -0)
➖ crates/server/src/store/in_memory/authority.rs (+0 -1666)
➕ crates/server/src/store/in_memory/inner.rs (+867 -0)
📝 crates/server/src/store/in_memory/mod.rs (+803 -2)

📄 Description

Includes a bunch of refactoring to make this code simpler. Replaces:

#2883
#2884

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2885 **Author:** [@djc](https://github.com/djc) **Created:** 3/25/2025 **Status:** ✅ Merged **Merged:** 3/25/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `authority-tweaks` --- ### 📝 Commits (10+) - [`2813867`](https://github.com/hickory-dns/hickory-dns/commit/28138675fa68626991b2707a16b04c914142e321) server: extract closure into method - [`8ba8220`](https://github.com/hickory-dns/hickory-dns/commit/8ba8220bddd928b136e09712e2f4f22a09fdfe6d) server: move InMemoryAuthority impls closer to type definition - [`18928a3`](https://github.com/hickory-dns/hickory-dns/commit/18928a3a85e58ee01a9e4ab9e483352c50d1cb0e) server: remove get_() prefix from private method - [`ed3c178`](https://github.com/hickory-dns/hickory-dns/commit/ed3c178b9be661da8f472ca7ac2b0b8a1c1c7abc) server: reduce rightward drift in InnerInMemory::proof() - [`70eaa22`](https://github.com/hickory-dns/hickory-dns/commit/70eaa227ddfccfe9687151b86a203bd9965eaa56) server: reduce rightward drift in InnerInMemory::proof() more - [`1d5fa22`](https://github.com/hickory-dns/hickory-dns/commit/1d5fa2284e6f246dea7d088fa41dd750038ddbd4) server: simplify wildcard match handling - [`4883d03`](https://github.com/hickory-dns/hickory-dns/commit/4883d03074f5f699a3b26b7ad87c4244821e01cb) server: further linearize InnerInMemory::proof() - [`9dec262`](https://github.com/hickory-dns/hickory-dns/commit/9dec262c59fb8bd136550aa3836d9feac98b8eb7) server: deduplicate NSEC3 records in response - [`92faf1f`](https://github.com/hickory-dns/hickory-dns/commit/92faf1f9acfd5f3b300084e7457c5fb65d9d6739) server: remove module indirection - [`70c3b2c`](https://github.com/hickory-dns/hickory-dns/commit/70c3b2cb8b3ea036dcf225567ce417285d06fd79) server: move InnerInMemory into a separate module ### 📊 Changes **5 files changed** (+1746 additions, -1668 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/basic.rs` (+38 -0) 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+38 -0) ➖ `crates/server/src/store/in_memory/authority.rs` (+0 -1666) ➕ `crates/server/src/store/in_memory/inner.rs` (+867 -0) 📝 `crates/server/src/store/in_memory/mod.rs` (+803 -2) </details> ### 📄 Description Includes a bunch of refactoring to make this code simpler. Replaces: - #2883 - #2884 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>