[PR #2876] [MERGED] Use GitHub Actions cache backend for Docker #3392

New issue

Closed

opened 2026-03-16 11:41:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:41:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2876
Author: @divergentdave
Created: 3/19/2025
Status: ✅ Merged
Merged: 3/21/2025
Merged by: @djc

Base: main ← Head: david/docker-gha-cache

📝 Commits (4)

e582d4d Use docker-container driver
72a814d Do more context directory setup only once
c507dea Use GitHub Actions cache backend
f864f3b Require DNSSEC feature to be explicitly specified

📊 Changes

5 files changed (+91 additions, -51 deletions)

View changed files

📝 .github/workflows/conformance.yml (+16 -0)
📝 conformance/README.md (+6 -1)
📝 conformance/packages/dns-test/src/container.rs (+59 -37)
📝 conformance/packages/dns-test/src/implementation.rs (+3 -4)
📝 conformance/packages/dns-test/src/lib.rs (+7 -9)

📄 Description

This enables use of the GitHub Actions cache to cache Docker image layers for the conformance test. When the new environment variable DNS_TEST_DOCKER_CACHE_GHA is set, extra command line flags will be passed to docker build. This cache backend also requires using the docker-container build driver, so that is set up using the docker/setup-buildx-action workflow. I also made it required to explicitly choose a Hickory DNS DNSSEC feature when running conformance tests, to eliminate some untested edge cases and inconsistent behavior when no feature is selected.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2876 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 3/19/2025 **Status:** ✅ Merged **Merged:** 3/21/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/docker-gha-cache` --- ### 📝 Commits (4) - [`e582d4d`](https://github.com/hickory-dns/hickory-dns/commit/e582d4d7230948846bc89f320e8dd92f8ecf22df) Use docker-container driver - [`72a814d`](https://github.com/hickory-dns/hickory-dns/commit/72a814df1fe8656d7ebd9ec57d28697e0bcd92cc) Do more context directory setup only once - [`c507dea`](https://github.com/hickory-dns/hickory-dns/commit/c507dea466c41720b6d02438a56a5fb52b9215e5) Use GitHub Actions cache backend - [`f864f3b`](https://github.com/hickory-dns/hickory-dns/commit/f864f3b52f8e08d28927387feecd2d789ff1aeee) Require DNSSEC feature to be explicitly specified ### 📊 Changes **5 files changed** (+91 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/conformance.yml` (+16 -0) 📝 `conformance/README.md` (+6 -1) 📝 `conformance/packages/dns-test/src/container.rs` (+59 -37) 📝 `conformance/packages/dns-test/src/implementation.rs` (+3 -4) 📝 `conformance/packages/dns-test/src/lib.rs` (+7 -9) </details> ### 📄 Description This enables use of the GitHub Actions cache to cache Docker image layers for the conformance test. When the new environment variable `DNS_TEST_DOCKER_CACHE_GHA` is set, extra command line flags will be passed to `docker build`. This cache backend also requires using the `docker-container` build driver, so that is set up using the `docker/setup-buildx-action` workflow. I also made it required to explicitly choose a Hickory DNS DNSSEC feature when running conformance tests, to eliminate some untested edge cases and inconsistent behavior when no feature is selected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>