[PR #2865] [MERGED] Improve encapsulation of RecordTypeSet #3384

New issue

Closed

opened 2026-03-16 11:40:39 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:40:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2865
Author: @djc
Created: 3/17/2025
Status: ✅ Merged
Merged: 3/18/2025
Merged by: @djc

Base: main ← Head: dnssec-types

📝 Commits (6)

3818519 proto: inline trivial constructor
ba5411a proto: take abstract argument for RecordTypeSet::new()
2cd7a86 proto: stop exposing BTreeSet internals of RecordTypeSet
ad83828 proto: inline trait bounds
77eea02 proto: clean up RecordTypeSet encoding/decoding logic
f6f9120 proto: rename module to record_type_set

📊 Changes

11 files changed (+88 additions, -101 deletions)

View changed files

📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+1 -1)
📝 crates/proto/src/dnssec/dnssec_dns_handle/nsec3_validation.rs (+3 -6)
📝 crates/proto/src/dnssec/rdata/nsec.rs (+28 -18)
📝 crates/proto/src/dnssec/rdata/nsec3.rs (+15 -11)
📝 crates/proto/src/rr/mod.rs (+2 -2)
📝 crates/proto/src/rr/rdata/csync.rs (+9 -24)
📝 crates/proto/src/rr/record_type_set.rs (+22 -28)
📝 crates/proto/src/serialize/txt/parse_rdata.rs (+2 -3)
📝 crates/proto/src/serialize/txt/rdata_parsers/csync.rs (+3 -4)
📝 crates/server/src/store/in_memory/authority.rs (+1 -2)
📝 tests/integration-tests/tests/integration/catalog_tests.rs (+2 -2)

📄 Description

Followup from #2849 to strengthen the encapsulation.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2865 **Author:** [@djc](https://github.com/djc) **Created:** 3/17/2025 **Status:** ✅ Merged **Merged:** 3/18/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `dnssec-types` --- ### 📝 Commits (6) - [`3818519`](https://github.com/hickory-dns/hickory-dns/commit/3818519c5d1ecfe4cbaed81ee609a0ca0b53132f) proto: inline trivial constructor - [`ba5411a`](https://github.com/hickory-dns/hickory-dns/commit/ba5411afa91c2213255f2ecff98c1bcaeebeaaf4) proto: take abstract argument for RecordTypeSet::new() - [`2cd7a86`](https://github.com/hickory-dns/hickory-dns/commit/2cd7a86b23fa4a97af5451af70d31d931810189e) proto: stop exposing BTreeSet internals of RecordTypeSet - [`ad83828`](https://github.com/hickory-dns/hickory-dns/commit/ad838285cb1593b050955fe1c762aeb6f099bd62) proto: inline trait bounds - [`77eea02`](https://github.com/hickory-dns/hickory-dns/commit/77eea02e3f6d37fda8904945c190580926cff9ab) proto: clean up RecordTypeSet encoding/decoding logic - [`f6f9120`](https://github.com/hickory-dns/hickory-dns/commit/f6f9120c8460a381b3d41f724ea6705b89e27c9b) proto: rename module to record_type_set ### 📊 Changes **11 files changed** (+88 additions, -101 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+1 -1) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/nsec3_validation.rs` (+3 -6) 📝 `crates/proto/src/dnssec/rdata/nsec.rs` (+28 -18) 📝 `crates/proto/src/dnssec/rdata/nsec3.rs` (+15 -11) 📝 `crates/proto/src/rr/mod.rs` (+2 -2) 📝 `crates/proto/src/rr/rdata/csync.rs` (+9 -24) 📝 `crates/proto/src/rr/record_type_set.rs` (+22 -28) 📝 `crates/proto/src/serialize/txt/parse_rdata.rs` (+2 -3) 📝 `crates/proto/src/serialize/txt/rdata_parsers/csync.rs` (+3 -4) 📝 `crates/server/src/store/in_memory/authority.rs` (+1 -2) 📝 `tests/integration-tests/tests/integration/catalog_tests.rs` (+2 -2) </details> ### 📄 Description Followup from #2849 to strengthen the encapsulation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>