[PR #2868] [MERGED] Streaming parsing of `tshark` output #3382

New issue

Closed

opened 2026-03-16 11:40:39 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:40:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2868
Author: @divergentdave
Created: 3/17/2025
Status: ✅ Merged
Merged: 4/8/2025
Merged by: @djc

Base: main ← Head: david/tshark-wait-until

📝 Commits (3)

ce02954 Streaming parsing of tshark output
0573833 Add method to wait for specific packets
46c89f9 Use wait_until() to fix test flakiness

📊 Changes

2 files changed (+201 additions, -76 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs (+10 -2)
📝 conformance/packages/dns-test/src/tshark.rs (+191 -74)

📄 Description

This rewrites Tshark to stop using log messages on stderr, and instead stream captured packets from stdout. Then, a new wait_until() method is added that can monitor incoming packets. wait_until() additionally takes a timeout, to avoid hanging. This fixes #2835.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2868 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 3/17/2025 **Status:** ✅ Merged **Merged:** 4/8/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/tshark-wait-until` --- ### 📝 Commits (3) - [`ce02954`](https://github.com/hickory-dns/hickory-dns/commit/ce02954cf7b8b2ab90ebbbe2e7f64f310aa9e0f7) Streaming parsing of tshark output - [`0573833`](https://github.com/hickory-dns/hickory-dns/commit/0573833251d536de36cea9c66cab5aa8797ea6dd) Add method to wait for specific packets - [`46c89f9`](https://github.com/hickory-dns/hickory-dns/commit/46c89f9d8de38712aa8e64c79cb3fd88d6d95837) Use wait_until() to fix test flakiness ### 📊 Changes **2 files changed** (+201 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/regression.rs` (+10 -2) 📝 `conformance/packages/dns-test/src/tshark.rs` (+191 -74) </details> ### 📄 Description This rewrites `Tshark` to stop using log messages on stderr, and instead stream captured packets from stdout. Then, a new `wait_until()` method is added that can monitor incoming packets. `wait_until()` additionally takes a timeout, to avoid hanging. This fixes #2835. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>