[PR #2854] [MERGED] Fix NSEC3 opt out bug #3373

New issue

Closed

opened 2026-03-16 11:40:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:40:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2854
Author: @divergentdave
Created: 3/14/2025
Status: ✅ Merged
Merged: 3/15/2025
Merged by: @djc

Base: main ← Head: david/nsec3-opt-out-bug

📝 Commits (2)

57d27bd Add test for bug in NSEC3 opt-out validation
07c701a Fix NSEC3 opt-out validation

📊 Changes

2 files changed (+35 additions, -7 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/insecure.rs (+34 -3)
📝 crates/proto/src/dnssec/dnssec_dns_handle/nsec3_validation.rs (+1 -4)

📄 Description

This fixes #2851. Thanks to @msrd0 for the report, this would have been tricky to find otherwise!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2854 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 3/14/2025 **Status:** ✅ Merged **Merged:** 3/15/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/nsec3-opt-out-bug` --- ### 📝 Commits (2) - [`57d27bd`](https://github.com/hickory-dns/hickory-dns/commit/57d27bdf72be7426f3a1446ddd7fa777ad2d436b) Add test for bug in NSEC3 opt-out validation - [`07c701a`](https://github.com/hickory-dns/hickory-dns/commit/07c701a780bb2e1d49a9d669d1c4c75d3e976d15) Fix NSEC3 opt-out validation ### 📊 Changes **2 files changed** (+35 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/insecure.rs` (+34 -3) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/nsec3_validation.rs` (+1 -4) </details> ### 📄 Description This fixes #2851. Thanks to @msrd0 for the report, this would have been tricky to find otherwise! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>