[PR #2846] [MERGED] Add unit tests based on RFC 4034 examples #3368

New issue

Closed

opened 2026-03-16 11:39:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:39:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2846
Author: @divergentdave
Created: 3/13/2025
Status: ✅ Merged
Merged: 3/13/2025
Merged by: @divergentdave

Base: main ← Head: david/rfc4034-examples

📝 Commits (1)

2307fe7 Add unit tests based on RFC 4034 examples

📊 Changes

2 files changed (+82 additions, -0 deletions)

View changed files

📝 crates/proto/src/dnssec/rdata/nsec.rs (+33 -0)
📝 crates/proto/src/rr/domain/name.rs (+49 -0)

📄 Description

This adds a couple unit tests for completeness, using some easily-testable examples from the spec.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2846 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 3/13/2025 **Status:** ✅ Merged **Merged:** 3/13/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/rfc4034-examples` --- ### 📝 Commits (1) - [`2307fe7`](https://github.com/hickory-dns/hickory-dns/commit/2307fe7fd0b573dd96ad21f2b099f124c4e8ed29) Add unit tests based on RFC 4034 examples ### 📊 Changes **2 files changed** (+82 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/rdata/nsec.rs` (+33 -0) 📝 `crates/proto/src/rr/domain/name.rs` (+49 -0) </details> ### 📄 Description This adds a couple unit tests for completeness, using some easily-testable examples from the spec. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>