[PR #2830] [MERGED] Validating forwarder tests #3353

New issue

Closed

opened 2026-03-16 11:39:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:39:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2830
Author: @divergentdave
Created: 3/4/2025
Status: ✅ Merged
Merged: 3/9/2025
Merged by: @djc

Base: main ← Head: david/validating-forwarder-tests

📝 Commits (3)

4f2759e Add builder for Resolver
a5503c8 Add builder for ForwardAuthority
a54aaea Add tests for forwarder with validate = true

📊 Changes

19 files changed (+545 additions, -282 deletions)

View changed files

📝 bin/src/lib.rs (+3 -5)
📝 bin/tests/integration/forwarder.rs (+3 -1)
📝 crates/resolver/examples/custom_provider.rs (+7 -7)
📝 crates/resolver/examples/flush_cache.rs (+5 -3)
📝 crates/resolver/examples/global_resolver.rs (+2 -1)
📝 crates/resolver/examples/multithreaded_runtime.rs (+2 -1)
📝 crates/resolver/src/h2.rs (+5 -9)
📝 crates/resolver/src/h3.rs (+3 -6)
📝 crates/resolver/src/lib.rs (+20 -16)
📝 crates/resolver/src/quic.rs (+6 -10)
📝 crates/resolver/src/resolver.rs (+160 -162)
📝 crates/resolver/src/tests.rs (+6 -6)
📝 crates/resolver/src/tls.rs (+5 -9)
📝 crates/server/src/store/forwarder/authority.rs (+116 -43)
📝 crates/server/src/store/forwarder/mod.rs (+1 -1)
📝 tests/integration-tests/Cargo.toml (+1 -1)
📝 tests/integration-tests/tests/integration/main.rs (+1 -0)
➕ tests/integration-tests/tests/integration/validating_forwarder_tests.rs (+194 -0)
📝 util/src/bin/resolve.rs (+5 -1)

📄 Description

This adds new constructors for Resolver and ForwardAuthority that allow using trust anchors other than the bundled keys, and adds an ignored test for #2428, making use of the new constructors.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2830 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 3/4/2025 **Status:** ✅ Merged **Merged:** 3/9/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/validating-forwarder-tests` --- ### 📝 Commits (3) - [`4f2759e`](https://github.com/hickory-dns/hickory-dns/commit/4f2759e7d4a560663be1c961fe121e412eb1e899) Add builder for Resolver - [`a5503c8`](https://github.com/hickory-dns/hickory-dns/commit/a5503c80288c95327e1144493ac9ac8b8b720590) Add builder for ForwardAuthority - [`a54aaea`](https://github.com/hickory-dns/hickory-dns/commit/a54aaea15f3f2ae3aed5e09453d8c1ba8141da02) Add tests for forwarder with validate = true ### 📊 Changes **19 files changed** (+545 additions, -282 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/lib.rs` (+3 -5) 📝 `bin/tests/integration/forwarder.rs` (+3 -1) 📝 `crates/resolver/examples/custom_provider.rs` (+7 -7) 📝 `crates/resolver/examples/flush_cache.rs` (+5 -3) 📝 `crates/resolver/examples/global_resolver.rs` (+2 -1) 📝 `crates/resolver/examples/multithreaded_runtime.rs` (+2 -1) 📝 `crates/resolver/src/h2.rs` (+5 -9) 📝 `crates/resolver/src/h3.rs` (+3 -6) 📝 `crates/resolver/src/lib.rs` (+20 -16) 📝 `crates/resolver/src/quic.rs` (+6 -10) 📝 `crates/resolver/src/resolver.rs` (+160 -162) 📝 `crates/resolver/src/tests.rs` (+6 -6) 📝 `crates/resolver/src/tls.rs` (+5 -9) 📝 `crates/server/src/store/forwarder/authority.rs` (+116 -43) 📝 `crates/server/src/store/forwarder/mod.rs` (+1 -1) 📝 `tests/integration-tests/Cargo.toml` (+1 -1) 📝 `tests/integration-tests/tests/integration/main.rs` (+1 -0) ➕ `tests/integration-tests/tests/integration/validating_forwarder_tests.rs` (+194 -0) 📝 `util/src/bin/resolve.rs` (+5 -1) </details> ### 📄 Description This adds new constructors for `Resolver` and `ForwardAuthority` that allow using trust anchors other than the bundled keys, and adds an ignored test for #2428, making use of the new constructors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>