[PR #2828] [MERGED] proto: make Query fields public, remove QueryParts #3351

Closed
opened 2026-03-16 11:39:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2828
Author: @divergentdave
Created: 3/3/2025
Status: Merged
Merged: 3/3/2025
Merged by: @divergentdave

Base: mainHead: david/remove-query-parts


📝 Commits (1)

  • 95c25ea proto: make Query fields public, remove QueryParts

📊 Changes

2 files changed (+13 additions, -67 deletions)

View changed files

📝 crates/proto/src/op/query.rs (+12 -64)
📝 crates/proto/src/xfer/dns_handle.rs (+1 -3)

📄 Description

This is a follow-up to https://github.com/hickory-dns/hickory-dns/pull/2683#discussion_r1911010602 to remove the QueryParts struct.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2828 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 3/3/2025 **Status:** ✅ Merged **Merged:** 3/3/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/remove-query-parts` --- ### 📝 Commits (1) - [`95c25ea`](https://github.com/hickory-dns/hickory-dns/commit/95c25ea3c832aee85498b01d00da28541bf9c99e) proto: make Query fields public, remove QueryParts ### 📊 Changes **2 files changed** (+13 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/query.rs` (+12 -64) 📝 `crates/proto/src/xfer/dns_handle.rs` (+1 -3) </details> ### 📄 Description This is a follow-up to https://github.com/hickory-dns/hickory-dns/pull/2683#discussion_r1911010602 to remove the `QueryParts` struct. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:39:01 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3351
No description provided.