[PR #2820] [MERGED] resolver: simplify server ordering mechanics #3343

New issue

Closed

opened 2026-03-16 11:38:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:38:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2820
Author: @djc
Created: 3/2/2025
Status: ✅ Merged
Merged: 3/4/2025
Merged by: @djc

Base: main ← Head: simpler-ordering

📝 Commits (3)

0043a5d resolver: remove shuffle_dns_servers option
8bf2099 resolver: make ServerOrderingStrategy non-exhaustive
464e0eb Add CHANGELOG entry for ResolverOpts changes

📊 Changes

3 files changed (+6 additions, -16 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 crates/resolver/src/config.rs (+1 -3)
📝 crates/resolver/src/name_server/name_server_pool.rs (+2 -13)

📄 Description

Remove the ResolverOpts::shuffle_dns_servers option in favor of the ServerOrderingStrategy. From my analysis in #2402, it doesn't feel like the bool option is addign much value. Make ServerOrderingStrategy non_exhaustive so that we can add more strategies without the need for a semver-incompatible bump.

Fixes #2402.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2820 **Author:** [@djc](https://github.com/djc) **Created:** 3/2/2025 **Status:** ✅ Merged **Merged:** 3/4/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `simpler-ordering` --- ### 📝 Commits (3) - [`0043a5d`](https://github.com/hickory-dns/hickory-dns/commit/0043a5dede95b0fd2c24063a8586db4d6b7b1537) resolver: remove shuffle_dns_servers option - [`8bf2099`](https://github.com/hickory-dns/hickory-dns/commit/8bf2099e4abdcfe1215275763bdcb6a854ce60f7) resolver: make ServerOrderingStrategy non-exhaustive - [`464e0eb`](https://github.com/hickory-dns/hickory-dns/commit/464e0ebc97b8252bb6eef52e8369597c84f1ef3f) Add CHANGELOG entry for ResolverOpts changes ### 📊 Changes **3 files changed** (+6 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `crates/resolver/src/config.rs` (+1 -3) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+2 -13) </details> ### 📄 Description Remove the `ResolverOpts::shuffle_dns_servers` option in favor of the `ServerOrderingStrategy`. From my analysis in #2402, it doesn't feel like the `bool` option is addign much value. Make `ServerOrderingStrategy` `non_exhaustive` so that we can add more strategies without the need for a semver-incompatible bump. Fixes #2402. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>