[PR #2805] [MERGED] Simplify protocol feature names #3332

New issue

Closed

opened 2026-03-16 11:37:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:37:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2805
Author: @djc
Created: 2/26/2025
Status: ✅ Merged
Merged: 2/27/2025
Merged by: @djc

Base: main ← Head: simplify-features

📝 Commits (1)

0644d01 Simplify protocol feature names

📊 Changes

40 files changed (+455 additions, -456 deletions)

View changed files

📝 .github/workflows/test.yml (+8 -8)
📝 CHANGELOG.md (+3 -1)
📝 bin/Cargo.toml (+13 -13)
📝 bin/src/hickory-dns.rs (+15 -15)
📝 bin/src/lib.rs (+8 -8)
📝 bin/tests/integration/config_tests.rs (+5 -5)
📝 bin/tests/integration/named_https_tests.rs (+1 -1)
📝 bin/tests/integration/named_quic_tests.rs (+1 -1)
📝 bin/tests/integration/named_rustls_tests.rs (+1 -1)
📝 bin/tests/integration/server_harness/mod.rs (+6 -6)
📝 conformance/packages/dns-test/src/docker/hickory.Dockerfile (+1 -1)
📝 crates/client/Cargo.toml (+9 -9)
📝 crates/proto/Cargo.toml (+13 -13)
📝 crates/proto/src/error.rs (+20 -20)
📝 crates/proto/src/http/error.rs (+4 -4)
📝 crates/proto/src/http/mod.rs (+4 -4)
📝 crates/proto/src/http/request.rs (+4 -4)
📝 crates/proto/src/lib.rs (+5 -5)
📝 crates/proto/src/quic/mod.rs (+1 -1)
📝 crates/proto/src/runtime.rs (+7 -7)

...and 20 more files

📄 Description

The dns-over- prefix makes our protocol feature names substantially more verbose than they need to be, in a way that also seems somewhat unidiomatic in the crates ecosystem. We also now only support rustls for TLS, removing one dimension of our features. Rename features to focus on the protocol and crypto:

dns-over-rustls -> tls
dns-over-https-rustls -> https
dns-over-quic -> quic
dns-over-h3 -> h3

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2805 **Author:** [@djc](https://github.com/djc) **Created:** 2/26/2025 **Status:** ✅ Merged **Merged:** 2/27/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `simplify-features` --- ### 📝 Commits (1) - [`0644d01`](https://github.com/hickory-dns/hickory-dns/commit/0644d0172183aadb69ea991d6c0687fa677bb12c) Simplify protocol feature names ### 📊 Changes **40 files changed** (+455 additions, -456 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+8 -8) 📝 `CHANGELOG.md` (+3 -1) 📝 `bin/Cargo.toml` (+13 -13) 📝 `bin/src/hickory-dns.rs` (+15 -15) 📝 `bin/src/lib.rs` (+8 -8) 📝 `bin/tests/integration/config_tests.rs` (+5 -5) 📝 `bin/tests/integration/named_https_tests.rs` (+1 -1) 📝 `bin/tests/integration/named_quic_tests.rs` (+1 -1) 📝 `bin/tests/integration/named_rustls_tests.rs` (+1 -1) 📝 `bin/tests/integration/server_harness/mod.rs` (+6 -6) 📝 `conformance/packages/dns-test/src/docker/hickory.Dockerfile` (+1 -1) 📝 `crates/client/Cargo.toml` (+9 -9) 📝 `crates/proto/Cargo.toml` (+13 -13) 📝 `crates/proto/src/error.rs` (+20 -20) 📝 `crates/proto/src/http/error.rs` (+4 -4) 📝 `crates/proto/src/http/mod.rs` (+4 -4) 📝 `crates/proto/src/http/request.rs` (+4 -4) 📝 `crates/proto/src/lib.rs` (+5 -5) 📝 `crates/proto/src/quic/mod.rs` (+1 -1) 📝 `crates/proto/src/runtime.rs` (+7 -7) _...and 20 more files_ </details> ### 📄 Description The `dns-over-` prefix makes our protocol feature names substantially more verbose than they need to be, in a way that also seems somewhat unidiomatic in the crates ecosystem. We also now only support rustls for TLS, removing one dimension of our features. Rename features to focus on the protocol and crypto: - `dns-over-rustls` -> `tls` - `dns-over-https-rustls` -> `https` - `dns-over-quic` -> `quic` - `dns-over-h3` -> `h3` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>