[PR #2797] [MERGED] Add conformance test support for dnssec-aws-lc-rs #3327

New issue

Closed

opened 2026-03-16 11:37:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:37:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2797
Author: @djc
Created: 2/23/2025
Status: ✅ Merged
Merged: 2/24/2025
Merged by: @djc

Base: main ← Head: aws-lc-conformance

📝 Commits (1)

1847a0d Add conformance test support for dnssec-aws-lc-rs

📊 Changes

3 files changed (+11 additions, -0 deletions)

View changed files

📝 .github/workflows/conformance.yml (+3 -0)
📝 conformance/packages/dns-test/src/implementation.rs (+3 -0)
📝 justfile (+5 -0)

📄 Description

Not sure we should additional conformance runs for this in CI -- conformance is already very slow. More likely, given the maintenance state of ring, we should switch the default in CI over to aws-lc-rs soonish (after we can use aws-lc-rs for TLS, too).

(But, just conformance-hickory-aws-lc-rs passes for me locally.)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2797 **Author:** [@djc](https://github.com/djc) **Created:** 2/23/2025 **Status:** ✅ Merged **Merged:** 2/24/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `aws-lc-conformance` --- ### 📝 Commits (1) - [`1847a0d`](https://github.com/hickory-dns/hickory-dns/commit/1847a0d744f38b414bd48cb013bba2c7a1ecf103) Add conformance test support for dnssec-aws-lc-rs ### 📊 Changes **3 files changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/conformance.yml` (+3 -0) 📝 `conformance/packages/dns-test/src/implementation.rs` (+3 -0) 📝 `justfile` (+5 -0) </details> ### 📄 Description Not sure we should additional conformance runs for this in CI -- conformance is already very slow. More likely, given the maintenance state of ring, we should switch the default in CI over to aws-lc-rs soonish (after we can use aws-lc-rs for TLS, too). (But, `just conformance-hickory-aws-lc-rs` passes for me locally.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>