[PR #2767] [MERGED] proto: store PublicKeyBuf in DNSKEY #3303

New issue

Closed

opened 2026-03-16 11:36:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:36:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2767
Author: @djc
Created: 2/11/2025
Status: ✅ Merged
Merged: 2/11/2025
Merged by: @djc

Base: main ← Head: dns-key-buf

📝 Commits (1)

8574392 proto: store PublicKeyBuf in DNSKEY

📊 Changes

9 files changed (+106 additions, -70 deletions)

View changed files

📝 bin/tests/integration/server_harness/mod.rs (+5 -2)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+6 -3)
📝 crates/proto/src/dnssec/public_key.rs (+5 -1)
📝 crates/proto/src/dnssec/rdata/dnskey.rs (+29 -28)
📝 crates/proto/src/dnssec/rdata/ds.rs (+25 -7)
📝 crates/proto/src/dnssec/signer.rs (+3 -9)
📝 crates/proto/src/serialize/txt/rdata_parsers/dnskey.rs (+10 -7)
📝 crates/proto/src/serialize/txt/trust_anchor.rs (+9 -5)
📝 crates/proto/tests/integration/dnssec_presentation_format_tests.rs (+14 -8)

📄 Description

From reviewing #2756; this feels like it has slightly better type safety.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2767 **Author:** [@djc](https://github.com/djc) **Created:** 2/11/2025 **Status:** ✅ Merged **Merged:** 2/11/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `dns-key-buf` --- ### 📝 Commits (1) - [`8574392`](https://github.com/hickory-dns/hickory-dns/commit/85743927cfe4f30c066d26ebd5e382d3329d55bb) proto: store PublicKeyBuf in DNSKEY ### 📊 Changes **9 files changed** (+106 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/server_harness/mod.rs` (+5 -2) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+6 -3) 📝 `crates/proto/src/dnssec/public_key.rs` (+5 -1) 📝 `crates/proto/src/dnssec/rdata/dnskey.rs` (+29 -28) 📝 `crates/proto/src/dnssec/rdata/ds.rs` (+25 -7) 📝 `crates/proto/src/dnssec/signer.rs` (+3 -9) 📝 `crates/proto/src/serialize/txt/rdata_parsers/dnskey.rs` (+10 -7) 📝 `crates/proto/src/serialize/txt/trust_anchor.rs` (+9 -5) 📝 `crates/proto/tests/integration/dnssec_presentation_format_tests.rs` (+14 -8) </details> ### 📄 Description From reviewing #2756; this feels like it has slightly better type safety. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>