[PR #2766] [MERGED] Relax DS key tag collision check #3302

New issue

Closed

opened 2026-03-16 11:36:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:36:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2766
Author: @divergentdave
Created: 2/10/2025
Status: ✅ Merged
Merged: 2/11/2025
Merged by: @divergentdave

Base: main ← Head: david/relax-ds-key-tag-collision-check

📝 Commits (1)

7e9df62 Relax DS key tag collision check

📊 Changes

1 file changed (+15 additions, -10 deletions)

View changed files

📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+15 -10)

📄 Description

Due to this check in verify_dnskey(), the function currently only checks the first two DS records, and ignores all others. This PR relaxes the limit to only count the number of DS records with matching algorithms and key tags. This better matches the initial intent and log messages.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2766 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 2/10/2025 **Status:** ✅ Merged **Merged:** 2/11/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/relax-ds-key-tag-collision-check` --- ### 📝 Commits (1) - [`7e9df62`](https://github.com/hickory-dns/hickory-dns/commit/7e9df62e5dac6e5bc3f9213276a52788e961d40a) Relax DS key tag collision check ### 📊 Changes **1 file changed** (+15 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+15 -10) </details> ### 📄 Description Due to this check in `verify_dnskey()`, the function currently only checks the first two DS records, and ignores all others. This PR relaxes the limit to only count the number of DS records with matching algorithms and key tags. This better matches the initial intent and log messages. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>