[PR #2759] [MERGED] [0.24] bump ring to 0.17.8 #3296

New issue

Closed

opened 2026-03-16 11:36:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:36:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2759
Author: @drahnr
Created: 2/10/2025
Status: ✅ Merged
Merged: 2/14/2025
Merged by: @djc

Base: release/0.24 ← Head: bernhard-bump-ring-release-0.24

📝 Commits (3)

19fe4d8 chore/dependency(ring): bump to 0.17.8
4a835dd feat: add err log if not matching the expected kind
4824b33 fix/test: use .1 ending of IP address in test, .0 will yield a different error

📊 Changes

5 files changed (+10 additions, -9 deletions)

View changed files

📝 Cargo.lock (+1 -1)
📝 Cargo.toml (+1 -1)
📝 crates/proto/src/rr/dnssec/key_format.rs (+2 -1)
📝 crates/proto/src/rr/dnssec/rdata/tsig.rs (+3 -3)
📝 tests/integration-tests/tests/client_tests.rs (+3 -3)

📄 Description

Currently ring 0.16.x fails to build for Win on Aarch64/Arm64 and with no intent to address it for 0.16.x release ¹. Users of the library must bump ring to 0.17.x to get a fix. With i.e. sccache looking to get rid of openssl as a dependency ², and having hickory-dns as a direct and hence affected ring as a transient dependency, I'd very much appreciate getting this merged, with the 0.25 seemingly still pending a refactor ³.

Context:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2759 **Author:** [@drahnr](https://github.com/drahnr) **Created:** 2/10/2025 **Status:** ✅ Merged **Merged:** 2/14/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `release/0.24` ← **Head:** `bernhard-bump-ring-release-0.24` --- ### 📝 Commits (3) - [`19fe4d8`](https://github.com/hickory-dns/hickory-dns/commit/19fe4d83d56a59d2d5fc9f30c8187f30a11a6fee) chore/dependency(ring): bump to 0.17.8 - [`4a835dd`](https://github.com/hickory-dns/hickory-dns/commit/4a835dd7790242521f63f0e5833b962c8a3d9025) feat: add err log if not matching the expected kind - [`4824b33`](https://github.com/hickory-dns/hickory-dns/commit/4824b33f0562104564370b9c3359d3909e044028) fix/test: use .1 ending of IP address in test, .0 will yield a different error ### 📊 Changes **5 files changed** (+10 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -1) 📝 `Cargo.toml` (+1 -1) 📝 `crates/proto/src/rr/dnssec/key_format.rs` (+2 -1) 📝 `crates/proto/src/rr/dnssec/rdata/tsig.rs` (+3 -3) 📝 `tests/integration-tests/tests/client_tests.rs` (+3 -3) </details> ### 📄 Description Currently ring 0.16.x fails to build for Win on Aarch64/Arm64 and with no intent to address it for 0.16.x release [^1]. Users of the library must bump ring to 0.17.x to get a fix. With i.e. sccache looking to get rid of `openssl` as a dependency [^2], and having `hickory-dns` as a direct and hence affected ring as a transient dependency, I'd very much appreciate getting this merged, with the `0.25` seemingly still pending a refactor [^3]. Context: [^1]: https://github.com/briansmith/ring/issues/1167#issuecomment-1745560468 [^2]: https://github.com/mozilla/sccache/pull/2325 [^3]: https://github.com/hickory-dns/hickory-dns/issues/2206 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>