[PR #2747] [MERGED] Initialize tracing subscriber in more tests #3283

New issue

Closed

opened 2026-03-16 11:35:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:35:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2747
Author: @divergentdave
Created: 1/30/2025
Status: ✅ Merged
Merged: 2/8/2025
Merged by: @divergentdave

Base: main ← Head: david/test-tracing-subscriber

📝 Commits (1)

281bfda Initialize tracing subscriber in more tests

📊 Changes

52 files changed (+345 additions, -27 deletions)

View changed files

📝 Cargo.lock (+2 -0)
📝 bin/tests/integration/authority_battery/dnssec.rs (+1 -0)
📝 bin/tests/integration/authority_battery/dynamic_update.rs (+1 -0)
📝 bin/tests/integration/forwarder.rs (+3 -0)
📝 bin/tests/integration/in_memory.rs (+3 -0)
📝 bin/tests/integration/named_rustls_tests.rs (+3 -0)
📝 bin/tests/integration/named_test_rsa_dnssec.rs (+9 -0)
📝 bin/tests/integration/named_tests.rs (+9 -0)
📝 bin/tests/integration/store_file_tests.rs (+4 -0)
📝 bin/tests/integration/timeout_stream_tests.rs (+5 -0)
📝 bin/tests/integration/txt_tests.rs (+11 -0)
📝 crates/async-std-resolver/src/tests.rs (+1 -0)
📝 crates/client/Cargo.toml (+1 -0)
📝 crates/client/src/client/client.rs (+10 -0)
📝 crates/client/src/client/memoize_client_handle.rs (+3 -0)
📝 crates/client/src/tests.rs (+4 -0)
📝 crates/proto/src/h2/h2_server.rs (+3 -0)
📝 crates/proto/src/h3/h3_client_stream.rs (+2 -0)
📝 crates/proto/src/multicast/mdns_stream.rs (+4 -0)
📝 crates/proto/src/quic/tests.rs (+3 -0)

...and 32 more files

📄 Description

This calls the tracing subscriber initialization helper from more tests. Having this initialization in place will save a step when debugging test failures. I skipped tests where I don't expect any interesting tracing events, such as tests just covering data structures, serialization, or future combinators, or anything using the dns-test framework.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2747 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 1/30/2025 **Status:** ✅ Merged **Merged:** 2/8/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/test-tracing-subscriber` --- ### 📝 Commits (1) - [`281bfda`](https://github.com/hickory-dns/hickory-dns/commit/281bfdad25ed917b176ad34acb75a9628ffccb31) Initialize tracing subscriber in more tests ### 📊 Changes **52 files changed** (+345 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+2 -0) 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+1 -0) 📝 `bin/tests/integration/authority_battery/dynamic_update.rs` (+1 -0) 📝 `bin/tests/integration/forwarder.rs` (+3 -0) 📝 `bin/tests/integration/in_memory.rs` (+3 -0) 📝 `bin/tests/integration/named_rustls_tests.rs` (+3 -0) 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+9 -0) 📝 `bin/tests/integration/named_tests.rs` (+9 -0) 📝 `bin/tests/integration/store_file_tests.rs` (+4 -0) 📝 `bin/tests/integration/timeout_stream_tests.rs` (+5 -0) 📝 `bin/tests/integration/txt_tests.rs` (+11 -0) 📝 `crates/async-std-resolver/src/tests.rs` (+1 -0) 📝 `crates/client/Cargo.toml` (+1 -0) 📝 `crates/client/src/client/client.rs` (+10 -0) 📝 `crates/client/src/client/memoize_client_handle.rs` (+3 -0) 📝 `crates/client/src/tests.rs` (+4 -0) 📝 `crates/proto/src/h2/h2_server.rs` (+3 -0) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+2 -0) 📝 `crates/proto/src/multicast/mdns_stream.rs` (+4 -0) 📝 `crates/proto/src/quic/tests.rs` (+3 -0) _...and 32 more files_ </details> ### 📄 Description This calls the tracing subscriber initialization helper from more tests. Having this initialization in place will save a step when debugging test failures. I skipped tests where I don't expect any interesting tracing events, such as tests just covering data structures, serialization, or future combinators, or anything using the dns-test framework. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>