[PR #2740] [MERGED] Ignore response ECS scope prefix-length in tests #3278

Closed
opened 2026-03-16 11:34:57 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2740
Author: @divergentdave
Created: 1/24/2025
Status: Merged
Merged: 1/24/2025
Merged by: @divergentdave

Base: mainHead: david/fix-ecs-flake


📝 Commits (1)

  • d2fc8ba Ignore response ECS scope prefix-length in tests

📊 Changes

2 files changed (+26 additions, -21 deletions)

View changed files

📝 tests/integration-tests/tests/integration/client_future_tests.rs (+13 -11)
📝 tests/integration-tests/tests/integration/client_tests.rs (+13 -10)

📄 Description

Fixes #2736. Since the scope prefix length is determined by the server, we shouldn't expect it to be zero. This is likely a new problem because of www.example.com moving to Akamai, see also #2728.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2740 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 1/24/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/fix-ecs-flake` --- ### 📝 Commits (1) - [`d2fc8ba`](https://github.com/hickory-dns/hickory-dns/commit/d2fc8bac212af4314d4996dc62932697440e849c) Ignore response ECS scope prefix-length in tests ### 📊 Changes **2 files changed** (+26 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `tests/integration-tests/tests/integration/client_future_tests.rs` (+13 -11) 📝 `tests/integration-tests/tests/integration/client_tests.rs` (+13 -10) </details> ### 📄 Description Fixes #2736. Since the scope prefix length is determined by the server, we shouldn't expect it to be zero. This is likely a new problem because of `www.example.com` moving to Akamai, see also #2728. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:34:57 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3278
No description provided.