[PR #2735] [MERGED] Refactor TLS configuration handling #3274

New issue

Closed

opened 2026-03-16 11:34:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:34:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2735
Author: @djc
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/30/2025
Merged by: @djc

Base: main ← Head: tls-config

📝 Commits (6)

2f4072b resolver: move TLS config from NameServerConfig to ResolverOpts
58b4a07 Remove unused dependencies
85f6804 resolver: discard identical nested guards
84a7272 Switch from rustls-native-certs to rustls-platform-verifier
68b6b1a resolver: discard static TLS client config
3846b91 resolver: require ResolverOpts to hold a TLS config

📊 Changes

30 files changed (+287 additions, -353 deletions)

View changed files

📝 Cargo.lock (+169 -3)
📝 Cargo.toml (+1 -1)
📝 bin/Cargo.toml (+2 -2)
📝 bin/src/lib.rs (+2 -2)
📝 crates/client/Cargo.toml (+1 -1)
📝 crates/proto/Cargo.toml (+2 -2)
📝 crates/proto/src/error.rs (+0 -7)
📝 crates/proto/src/h2/h2_client_stream.rs (+2 -2)
📝 crates/proto/src/h3/h3_client_stream.rs (+9 -6)
📝 crates/proto/src/quic/quic_client_stream.rs (+1 -1)
📝 crates/proto/src/rustls/mod.rs (+21 -33)
📝 crates/resolver/Cargo.toml (+1 -2)
📝 crates/resolver/examples/custom_provider.rs (+7 -7)
📝 crates/resolver/src/config.rs (+13 -73)
📝 crates/resolver/src/h2.rs (+5 -24)
📝 crates/resolver/src/h3.rs (+6 -28)
📝 crates/resolver/src/name_server/connection_provider.rs (+11 -27)
📝 crates/resolver/src/name_server/name_server.rs (+0 -4)
📝 crates/resolver/src/name_server/name_server_pool.rs (+2 -26)
📝 crates/resolver/src/quic.rs (+16 -35)

...and 10 more files

📄 Description

Fixes #2038.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2735 **Author:** [@djc](https://github.com/djc) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/30/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `tls-config` --- ### 📝 Commits (6) - [`2f4072b`](https://github.com/hickory-dns/hickory-dns/commit/2f4072b02f87ad977c532cfba18d2431cd7dedaa) resolver: move TLS config from NameServerConfig to ResolverOpts - [`58b4a07`](https://github.com/hickory-dns/hickory-dns/commit/58b4a073d3b48c44d2a577c7e66ce7ca3d0a280e) Remove unused dependencies - [`85f6804`](https://github.com/hickory-dns/hickory-dns/commit/85f680495d9107a445577fb52290871911a9b8c2) resolver: discard identical nested guards - [`84a7272`](https://github.com/hickory-dns/hickory-dns/commit/84a7272f55f117461b60b09502774a5c2e358502) Switch from rustls-native-certs to rustls-platform-verifier - [`68b6b1a`](https://github.com/hickory-dns/hickory-dns/commit/68b6b1a650184412591924441dbc50d0644e05dc) resolver: discard static TLS client config - [`3846b91`](https://github.com/hickory-dns/hickory-dns/commit/3846b914d54afd5a354bbbd8e96efadd84e2e42d) resolver: require ResolverOpts to hold a TLS config ### 📊 Changes **30 files changed** (+287 additions, -353 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+169 -3) 📝 `Cargo.toml` (+1 -1) 📝 `bin/Cargo.toml` (+2 -2) 📝 `bin/src/lib.rs` (+2 -2) 📝 `crates/client/Cargo.toml` (+1 -1) 📝 `crates/proto/Cargo.toml` (+2 -2) 📝 `crates/proto/src/error.rs` (+0 -7) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+2 -2) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+9 -6) 📝 `crates/proto/src/quic/quic_client_stream.rs` (+1 -1) 📝 `crates/proto/src/rustls/mod.rs` (+21 -33) 📝 `crates/resolver/Cargo.toml` (+1 -2) 📝 `crates/resolver/examples/custom_provider.rs` (+7 -7) 📝 `crates/resolver/src/config.rs` (+13 -73) 📝 `crates/resolver/src/h2.rs` (+5 -24) 📝 `crates/resolver/src/h3.rs` (+6 -28) 📝 `crates/resolver/src/name_server/connection_provider.rs` (+11 -27) 📝 `crates/resolver/src/name_server/name_server.rs` (+0 -4) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+2 -26) 📝 `crates/resolver/src/quic.rs` (+16 -35) _...and 10 more files_ </details> ### 📄 Description Fixes #2038. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>