[PR #2728] [MERGED] Fix test failures due to example.com changes #3267

New issue

Closed

opened 2026-03-16 11:34:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:34:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2728
Author: @divergentdave
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @djc

Base: main ← Head: david/example-dot-com-changes

📝 Commits (1)

66d407b Fix test failures due to example.com changes

📊 Changes

20 files changed (+107 additions, -324 deletions)

View changed files

📝 bin/tests/integration/forwarder.rs (+4 -4)
📝 bin/tests/integration/named_tests.rs (+8 -9)
📝 crates/async-std-resolver/src/lib.rs (+1 -6)
📝 crates/client/README.md (+8 -7)
📝 crates/client/src/tests.rs (+7 -7)
📝 crates/proto/src/h2/h2_client_stream.rs (+19 -9)
📝 crates/proto/src/h3/h3_client_stream.rs (+19 -9)
📝 crates/resolver/README.md (+1 -7)
📝 crates/resolver/examples/custom_provider.rs (+2 -14)
📝 crates/resolver/src/h2.rs (+2 -28)
📝 crates/resolver/src/h3.rs (+2 -28)
📝 crates/resolver/src/lib.rs (+1 -6)
📝 crates/resolver/src/name_server/name_server_pool.rs (+3 -15)
📝 crates/resolver/src/quic.rs (+3 -27)
📝 crates/resolver/src/resolver.rs (+16 -61)
📝 crates/resolver/src/tests.rs (+1 -13)
📝 crates/resolver/src/tls.rs (+1 -15)
📝 tests/integration-tests/tests/integration/client_future_tests.rs (+5 -25)
📝 tests/integration-tests/tests/integration/client_tests.rs (+2 -20)
📝 tests/integration-tests/tests/integration/dnssec_client_handle_tests.rs (+2 -14)

📄 Description

This removes or relaxes assertions about responses we get when querying www.example.com. in tests. It also sets the maximum buffer size in some low-level transport tests. We no longer check the IP address returned, since we could now get almost any Akamai server, instead we just check that we got at least one record, or at least one record of a particular type. Fixes #2724.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2728 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/example-dot-com-changes` --- ### 📝 Commits (1) - [`66d407b`](https://github.com/hickory-dns/hickory-dns/commit/66d407b89ce2a89f3bb6891ca8ddd4d71a1b525d) Fix test failures due to example.com changes ### 📊 Changes **20 files changed** (+107 additions, -324 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/forwarder.rs` (+4 -4) 📝 `bin/tests/integration/named_tests.rs` (+8 -9) 📝 `crates/async-std-resolver/src/lib.rs` (+1 -6) 📝 `crates/client/README.md` (+8 -7) 📝 `crates/client/src/tests.rs` (+7 -7) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+19 -9) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+19 -9) 📝 `crates/resolver/README.md` (+1 -7) 📝 `crates/resolver/examples/custom_provider.rs` (+2 -14) 📝 `crates/resolver/src/h2.rs` (+2 -28) 📝 `crates/resolver/src/h3.rs` (+2 -28) 📝 `crates/resolver/src/lib.rs` (+1 -6) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+3 -15) 📝 `crates/resolver/src/quic.rs` (+3 -27) 📝 `crates/resolver/src/resolver.rs` (+16 -61) 📝 `crates/resolver/src/tests.rs` (+1 -13) 📝 `crates/resolver/src/tls.rs` (+1 -15) 📝 `tests/integration-tests/tests/integration/client_future_tests.rs` (+5 -25) 📝 `tests/integration-tests/tests/integration/client_tests.rs` (+2 -20) 📝 `tests/integration-tests/tests/integration/dnssec_client_handle_tests.rs` (+2 -14) </details> ### 📄 Description This removes or relaxes assertions about responses we get when querying `www.example.com.` in tests. It also sets the maximum buffer size in some low-level transport tests. We no longer check the IP address returned, since we could now get almost any Akamai server, instead we just check that we got at least one record, or at least one record of a particular type. Fixes #2724. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>