[PR #2700] [MERGED] proto: remove DigestType::SHA512 #3254

New issue

Closed

opened 2026-03-16 11:33:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:33:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2700
Author: @divergentdave
Created: 12/23/2024
Status: ✅ Merged
Merged: 12/23/2024
Merged by: @djc

Base: main ← Head: david/remove-sha-512-ds

📝 Commits (1)

4f13166 proto: remove DigestType::SHA512

📊 Changes

2 files changed (+0 additions, -4 deletions)

View changed files

📝 crates/proto/src/dnssec/mod.rs (+0 -3)
📝 crates/proto/src/dnssec/ring.rs (+0 -1)

📄 Description

This removes the SHA512 variant from DigestType. As discussed in #2695, the conversion from Algorithm to DigestType is no longer used in RRSIG signing and verification, so this variant is no longer necessary. DigestType now only represents DS digest algorithms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2700 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 12/23/2024 **Status:** ✅ Merged **Merged:** 12/23/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/remove-sha-512-ds` --- ### 📝 Commits (1) - [`4f13166`](https://github.com/hickory-dns/hickory-dns/commit/4f131666d417b7190400b6644159dbc36bce1d06) proto: remove DigestType::SHA512 ### 📊 Changes **2 files changed** (+0 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/mod.rs` (+0 -3) 📝 `crates/proto/src/dnssec/ring.rs` (+0 -1) </details> ### 📄 Description This removes the `SHA512` variant from `DigestType`. As discussed in #2695, the conversion from `Algorithm` to `DigestType` is no longer used in RRSIG signing and verification, so this variant is no longer necessary. `DigestType` now only represents DS digest algorithms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>