[PR #2691] [MERGED] Minimize DNSSEC guards some more #3241

New issue

Closed

opened 2026-03-16 11:33:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:33:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2691
Author: @djc
Created: 12/19/2024
Status: ✅ Merged
Merged: 12/20/2024
Merged by: @djc

Base: main ← Head: dnssec-guard

📝 Commits (5)

65c4bd1 proto: move DnsSecError et al into dnssec
9238c10 proto: move DNSSEC error variants into DnsSecErrorKind
6960486 proto: remove more unnecessary guards
16517fd proto: move decode_public_key() implementation
dabc2ee proto: move DnssecDnsHandle into dnssec module

📊 Changes

23 files changed (+242 additions, -288 deletions)

View changed files

📝 bin/tests/integration/authority_battery/dnssec.rs (+5 -25)
📝 bin/tests/integration/named_test_rsa_dnssec.rs (+1 -2)
📝 crates/client/src/client/dnssec_client.rs (+1 -1)
📝 crates/client/src/error.rs (+1 -1)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+1 -1)
📝 crates/proto/src/dnssec/dnssec_dns_handle/nsec3_validation.rs (+0 -0)
📝 crates/proto/src/dnssec/mod.rs (+159 -3)
📝 crates/proto/src/dnssec/proof.rs (+2 -3)
📝 crates/proto/src/dnssec/public_key.rs (+1 -33)
📝 crates/proto/src/dnssec/rdata/dnskey.rs (+1 -1)
📝 crates/proto/src/dnssec/rdata/ds.rs (+2 -2)
📝 crates/proto/src/dnssec/rdata/key.rs (+2 -2)
📝 crates/proto/src/dnssec/rdata/tsig.rs (+9 -8)
📝 crates/proto/src/dnssec/ring.rs (+28 -5)
📝 crates/proto/src/dnssec/signer.rs (+2 -4)
📝 crates/proto/src/dnssec/tsig.rs (+18 -18)
📝 crates/proto/src/error.rs (+4 -164)
📝 crates/proto/src/lib.rs (+0 -5)
📝 crates/proto/src/xfer/mod.rs (+0 -4)
📝 crates/recursor/src/recursor.rs (+2 -2)

...and 3 more files

📄 Description

More preparation for introducing an aws-lc-rs backend (it's close, I promise!).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2691 **Author:** [@djc](https://github.com/djc) **Created:** 12/19/2024 **Status:** ✅ Merged **Merged:** 12/20/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `dnssec-guard` --- ### 📝 Commits (5) - [`65c4bd1`](https://github.com/hickory-dns/hickory-dns/commit/65c4bd1ce42a421d79d66c15df718f56da84a70b) proto: move DnsSecError et al into dnssec - [`9238c10`](https://github.com/hickory-dns/hickory-dns/commit/9238c1042366fc18429b0321bb259d994f771faa) proto: move DNSSEC error variants into DnsSecErrorKind - [`6960486`](https://github.com/hickory-dns/hickory-dns/commit/69604869e228d39d70f217cc4a16bb32b1cf9cdb) proto: remove more unnecessary guards - [`16517fd`](https://github.com/hickory-dns/hickory-dns/commit/16517fd37df55031ccf5ea386c51d3b0ff6f7e1c) proto: move decode_public_key() implementation - [`dabc2ee`](https://github.com/hickory-dns/hickory-dns/commit/dabc2eed73ede3b54f6e0b6b57849fb7979dc039) proto: move DnssecDnsHandle into dnssec module ### 📊 Changes **23 files changed** (+242 additions, -288 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+5 -25) 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+1 -2) 📝 `crates/client/src/client/dnssec_client.rs` (+1 -1) 📝 `crates/client/src/error.rs` (+1 -1) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+1 -1) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/nsec3_validation.rs` (+0 -0) 📝 `crates/proto/src/dnssec/mod.rs` (+159 -3) 📝 `crates/proto/src/dnssec/proof.rs` (+2 -3) 📝 `crates/proto/src/dnssec/public_key.rs` (+1 -33) 📝 `crates/proto/src/dnssec/rdata/dnskey.rs` (+1 -1) 📝 `crates/proto/src/dnssec/rdata/ds.rs` (+2 -2) 📝 `crates/proto/src/dnssec/rdata/key.rs` (+2 -2) 📝 `crates/proto/src/dnssec/rdata/tsig.rs` (+9 -8) 📝 `crates/proto/src/dnssec/ring.rs` (+28 -5) 📝 `crates/proto/src/dnssec/signer.rs` (+2 -4) 📝 `crates/proto/src/dnssec/tsig.rs` (+18 -18) 📝 `crates/proto/src/error.rs` (+4 -164) 📝 `crates/proto/src/lib.rs` (+0 -5) 📝 `crates/proto/src/xfer/mod.rs` (+0 -4) 📝 `crates/recursor/src/recursor.rs` (+2 -2) _...and 3 more files_ </details> ### 📄 Description More preparation for introducing an aws-lc-rs backend (it's close, I promise!). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>