[PR #2676] [CLOSED] proto: refactor NSEC3 hashing into a loop #3229

New issue

Closed

opened 2026-03-16 11:32:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:32:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2676
Author: @divergentdave
Created: 12/13/2024
Status: ❌ Closed

Base: main ← Head: david/nsec3-iterative

📝 Commits (1)

e4a299b proto: refactor NSEC3 hashing into a loop

📊 Changes

2 files changed (+26 additions, -11 deletions)

View changed files

📝 bin/tests/integration/authority_battery/dnssec.rs (+21 -2)
📝 crates/proto/src/dnssec/nsec3.rs (+5 -9)

📄 Description

This rewrites the NSEC3 hashing method to use a for loop instead of recursion. On my system, 65535 additional iterations can exhaust the stack with recursive stack frames.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2676 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 12/13/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `david/nsec3-iterative` --- ### 📝 Commits (1) - [`e4a299b`](https://github.com/hickory-dns/hickory-dns/commit/e4a299b302e48ed847637454760b68c664359696) proto: refactor NSEC3 hashing into a loop ### 📊 Changes **2 files changed** (+26 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+21 -2) 📝 `crates/proto/src/dnssec/nsec3.rs` (+5 -9) </details> ### 📄 Description This rewrites the NSEC3 hashing method to use a for loop instead of recursion. On my system, 65535 additional iterations can exhaust the stack with recursive stack frames. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>