[PR #2663] [CLOSED] Add timeouts to some flaky tests #3219

New issue

Closed

opened 2026-03-16 11:31:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:31:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2663
Author: @divergentdave
Created: 12/9/2024
Status: ❌ Closed

Base: main ← Head: david/test-timeouts

📝 Commits (1)

ddc579c Add timeouts to some flaky tests

📊 Changes

3 files changed (+60 additions, -27 deletions)

View changed files

📝 crates/proto/src/tests/udp.rs (+10 -9)
📝 tests/integration-tests/tests/integration/name_server_pool_tests.rs (+38 -16)
📝 tests/integration-tests/tests/integration/server_future_tests.rs (+12 -2)

📄 Description

I noticed a couple recent test flakes where tests got stuck. This PR adds timeouts around some relevant futures, both in those tests and others with similar comments. This will at least fail quicker, and provide us some diagnostic information.

I had to change a few tests from futures-executor to a current-thread Tokio runtime, since the former doesn't provide a timeout API, and the Tokio timeout() function can't be called from outside of a Tokio runtime.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2663 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 12/9/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `david/test-timeouts` --- ### 📝 Commits (1) - [`ddc579c`](https://github.com/hickory-dns/hickory-dns/commit/ddc579c312e69b1728d4f243e57a4fd81fc867c4) Add timeouts to some flaky tests ### 📊 Changes **3 files changed** (+60 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/tests/udp.rs` (+10 -9) 📝 `tests/integration-tests/tests/integration/name_server_pool_tests.rs` (+38 -16) 📝 `tests/integration-tests/tests/integration/server_future_tests.rs` (+12 -2) </details> ### 📄 Description I noticed a couple recent test flakes where tests got stuck. This PR adds timeouts around some relevant futures, both in those tests and others with similar comments. This will at least fail quicker, and provide us some diagnostic information. I had to change a few tests from `futures-executor` to a current-thread Tokio runtime, since the former doesn't provide a timeout API, and the Tokio `timeout()` function can't be called from outside of a Tokio runtime. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>