[PR #2656] [MERGED] Remove support for OpenSSL #3207

New issue

Closed

opened 2026-03-16 11:31:09 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:31:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2656
Author: @djc
Created: 12/9/2024
Status: ✅ Merged
Merged: 12/9/2024
Merged by: @djc

Base: main ← Head: rm-openssl

📝 Commits (10+)

b6053a1 util: remove support for OpenSSL-based tools
2173e96 tests: remove integration test support for OpenSSL
e13a462 proto: remove stub Digest type
c87d340 proto: clean up nsec3 tests
e6794fc proto: assume at least one DNSSEC impl is enabled
3948471 proto: remove stub error types
2e42546 proto: avoid unused imports in DS tests
e4d95ea bin: add integration tests for ring RSA keys
3697014 bin: switch tests from OpenSSL to ring
b72eac2 proto: move SigSigner tests to ring

📊 Changes

63 files changed (+386 additions, -3108 deletions)

View changed files

📝 .github/workflows/test.yml (+0 -3)
📝 Cargo.lock (+2 -141)
📝 Cargo.toml (+0 -4)
📝 bin/Cargo.toml (+1 -5)
📝 bin/src/dnssec.rs (+0 -68)
📝 bin/tests/integration/authority_battery/dnssec.rs (+3 -3)
📝 bin/tests/integration/authority_battery/dynamic_update.rs (+3 -3)
📝 bin/tests/integration/config_tests.rs (+0 -2)
📝 bin/tests/integration/main.rs (+0 -1)
➖ bin/tests/integration/named_openssl_tests.rs (+0 -85)
📝 bin/tests/integration/named_test_rsa_dnssec.rs (+19 -51)
📝 bin/tests/integration/server_harness/mod.rs (+1 -0)
📝 conformance/packages/dns-test/src/implementation.rs (+3 -7)
📝 crates/async-std-resolver/Cargo.toml (+0 -4)
📝 crates/client/Cargo.toml (+0 -3)
📝 crates/proto/Cargo.toml (+0 -12)
📝 crates/proto/src/dnssec/algorithm.rs (+2 -3)
📝 crates/proto/src/dnssec/digest_type.rs (+0 -44)
📝 crates/proto/src/dnssec/mod.rs (+2 -41)
📝 crates/proto/src/dnssec/nsec3.rs (+110 -108)

...and 43 more files

📄 Description

I think it makes sense to get this done before I add support for aws-lc-rs, since it clarifies where we need to add aws-lc-rs support (in a near-future PR).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2656 **Author:** [@djc](https://github.com/djc) **Created:** 12/9/2024 **Status:** ✅ Merged **Merged:** 12/9/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `rm-openssl` --- ### 📝 Commits (10+) - [`b6053a1`](https://github.com/hickory-dns/hickory-dns/commit/b6053a14b04e43fe025346e3a5163ae08630a804) util: remove support for OpenSSL-based tools - [`2173e96`](https://github.com/hickory-dns/hickory-dns/commit/2173e96c7c7f2d1610cd54ea03663d3d15fe072b) tests: remove integration test support for OpenSSL - [`e13a462`](https://github.com/hickory-dns/hickory-dns/commit/e13a462d2470ac5ed2ee7710bf22bdd79fd6d7c6) proto: remove stub Digest type - [`c87d340`](https://github.com/hickory-dns/hickory-dns/commit/c87d340d1170a25ee082a07ebfb548e1b7eef6be) proto: clean up nsec3 tests - [`e6794fc`](https://github.com/hickory-dns/hickory-dns/commit/e6794fcedabc064b98f16ef58bfa73407c84fb14) proto: assume at least one DNSSEC impl is enabled - [`3948471`](https://github.com/hickory-dns/hickory-dns/commit/3948471562917e38bdac8d38dda68973bf53643a) proto: remove stub error types - [`2e42546`](https://github.com/hickory-dns/hickory-dns/commit/2e42546c3e71417fab20cbc610ac5e5aad16316c) proto: avoid unused imports in DS tests - [`e4d95ea`](https://github.com/hickory-dns/hickory-dns/commit/e4d95eae373aa3254e5a27e7fc3366530e6ce17b) bin: add integration tests for ring RSA keys - [`3697014`](https://github.com/hickory-dns/hickory-dns/commit/3697014521a37aa6a2f6f43853bd011d4604212a) bin: switch tests from OpenSSL to ring - [`b72eac2`](https://github.com/hickory-dns/hickory-dns/commit/b72eac20b77ca9cbc09eac16b9a3d8a1ac5fcf6c) proto: move SigSigner tests to ring ### 📊 Changes **63 files changed** (+386 additions, -3108 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+0 -3) 📝 `Cargo.lock` (+2 -141) 📝 `Cargo.toml` (+0 -4) 📝 `bin/Cargo.toml` (+1 -5) 📝 `bin/src/dnssec.rs` (+0 -68) 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+3 -3) 📝 `bin/tests/integration/authority_battery/dynamic_update.rs` (+3 -3) 📝 `bin/tests/integration/config_tests.rs` (+0 -2) 📝 `bin/tests/integration/main.rs` (+0 -1) ➖ `bin/tests/integration/named_openssl_tests.rs` (+0 -85) 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+19 -51) 📝 `bin/tests/integration/server_harness/mod.rs` (+1 -0) 📝 `conformance/packages/dns-test/src/implementation.rs` (+3 -7) 📝 `crates/async-std-resolver/Cargo.toml` (+0 -4) 📝 `crates/client/Cargo.toml` (+0 -3) 📝 `crates/proto/Cargo.toml` (+0 -12) 📝 `crates/proto/src/dnssec/algorithm.rs` (+2 -3) 📝 `crates/proto/src/dnssec/digest_type.rs` (+0 -44) 📝 `crates/proto/src/dnssec/mod.rs` (+2 -41) 📝 `crates/proto/src/dnssec/nsec3.rs` (+110 -108) _...and 43 more files_ </details> ### 📄 Description I think it makes sense to get this done before I add support for aws-lc-rs, since it clarifies where we need to add aws-lc-rs support (in a near-future PR). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>