[PR #2644] [MERGED] Remove redundant Resolver constructors #3200

New issue

Closed

opened 2026-03-16 11:30:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:30:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2644
Author: @divergentdave
Created: 12/5/2024
Status: ✅ Merged
Merged: 12/5/2024
Merged by: @djc

Base: main ← Head: david/remove-duplicate-constructors

📝 Commits (1)

27e9c07 Remove redundant Resolver constructors

📊 Changes

1 file changed (+22 additions, -43 deletions)

View changed files

📝 crates/resolver/src/resolver.rs (+22 -43)

📄 Description

This removes two duplicate constructors, Resolver::new_with_conn() and Resolver::from_system_conf_with_provider(), and inlines their bodies into Resolver::new() and Resolver::from_system_conf(), which have the same signatures and call them directly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2644 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 12/5/2024 **Status:** ✅ Merged **Merged:** 12/5/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/remove-duplicate-constructors` --- ### 📝 Commits (1) - [`27e9c07`](https://github.com/hickory-dns/hickory-dns/commit/27e9c070aff7661271aa542066db7a8fe652122b) Remove redundant Resolver constructors ### 📊 Changes **1 file changed** (+22 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/resolver.rs` (+22 -43) </details> ### 📄 Description This removes two duplicate constructors, `Resolver::new_with_conn()` and `Resolver::from_system_conf_with_provider()`, and inlines their bodies into `Resolver::new()` and `Resolver::from_system_conf()`, which have the same signatures and call them directly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>