mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 03:05:51 +03:00
[GH-ISSUE #50] Upgrade OpenSSL to 0.8.x #32
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#32
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @chaoticsmol on GitHub (Oct 9, 2016).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/50
Originally assigned to: @bluejekyll on GitHub.
Before the upgrade to ring, I'd like to request that trust-dns adopt rust-openssl version 0.8. I found in my use of rust-openssl in rust-ftp that some usage of rust-openssl version 0.7 lead to a memory error that was resolved immediately by the update to 0.8.
For a tiny bit more information, see the issue I opened on hyperium/hyper.
@bluejekyll commented on GitHub (Oct 10, 2016):
If you want to submit a PR for that, I'd happily accept.
@bluejekyll commented on GitHub (Oct 18, 2016):
I started work on this to hopefully fix Travis OSX builds, but man, openssl 0.8.0 is quite different from 0.7 :(
@chaoticsmol commented on GitHub (Oct 18, 2016):
It is pretty different. I'd have liked to get to this myself but have been over-loaded with other things.
@bluejekyll commented on GitHub (Oct 19, 2016):
2b14581is the conversion to openssl 0.8.While that's basically complete, of course my integration tests for the proof of a signed example.com are now failing :(
looking into it.
@bluejekyll commented on GitHub (Oct 19, 2016):
oh, and I have all the warnings related to the futures stuff cleaned up in a different branch. I'll be getting rid of those in a little bit.
@bluejekyll commented on GitHub (Oct 19, 2016):
Travis is passing again with this patch at least :)
@bluejekyll commented on GitHub (Oct 19, 2016):
FYI, looking more deeply, not all secure queries are failing, and some parts of the chain are validating properly. I'm not entirely able to say right now that there isn't a bug here. rollernet tests are all passing right now, which tells me that it's only example.com that is having issues.
It validates the www.example.com against example.com's DNSKEY, but then fails to validate the DNSKEY for example.com. But since rollertnet tests are functioning this might not be an issue with the upgrade.
@bluejekyll commented on GitHub (Oct 19, 2016):
cargo test -- --ignoredwill run all of the integration tests for anyone interested in looking at this.@bluejekyll commented on GitHub (Oct 20, 2016):
Ok, got to the bottom of it. In changing a bunch of interfaces to return Result (due to some of the changes in OpenSSL), I had made overzealous use of try!() and underthought placement in the validation loops for DNSSec. Everything checks out now.