[PR #2642] [MERGED] Clean up ignored tests #3195

New issue

Closed

opened 2026-03-16 11:30:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:30:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2642
Author: @divergentdave
Created: 12/5/2024
Status: ✅ Merged
Merged: 12/5/2024
Merged by: @marcus0x62

Base: main ← Head: david/ignored-tests

📝 Commits (3)

b3cc40f Clean up native-tls tests
045b38f Re-enable forwarder test
086826f Move comments to ignore reasons

📊 Changes

6 files changed (+20 additions, -25 deletions)

View changed files

📝 bin/tests/integration/forwarder.rs (+0 -1)
📝 crates/proto/src/h2/h2_client_stream.rs (+1 -1)
📝 crates/proto/src/h3/h3_client_stream.rs (+1 -1)
📝 crates/proto/src/native_tls/tests.rs (+8 -12)
📝 tests/integration-tests/tests/integration/client_tests.rs (+5 -5)
📝 tests/integration-tests/tests/integration/dnssec_client_handle_tests.rs (+5 -5)

📄 Description

This re-enables a couple tests, and sets the ignore reason field where there are existing explanatory comments.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2642 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 12/5/2024 **Status:** ✅ Merged **Merged:** 12/5/2024 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `david/ignored-tests` --- ### 📝 Commits (3) - [`b3cc40f`](https://github.com/hickory-dns/hickory-dns/commit/b3cc40f02a152a842bc4da5067a13f9e09a9ad87) Clean up native-tls tests - [`045b38f`](https://github.com/hickory-dns/hickory-dns/commit/045b38fec735b1221077db47be3b5c0304311a8e) Re-enable forwarder test - [`086826f`](https://github.com/hickory-dns/hickory-dns/commit/086826f2712f46297df5213d625bd850e9a03602) Move comments to ignore reasons ### 📊 Changes **6 files changed** (+20 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/forwarder.rs` (+0 -1) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+1 -1) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+1 -1) 📝 `crates/proto/src/native_tls/tests.rs` (+8 -12) 📝 `tests/integration-tests/tests/integration/client_tests.rs` (+5 -5) 📝 `tests/integration-tests/tests/integration/dnssec_client_handle_tests.rs` (+5 -5) </details> ### 📄 Description This re-enables a couple tests, and sets the ignore reason field where there are existing explanatory comments. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>